chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm - Issue 1009953002: Integrate ManagePasswordsState into ManagePasswordsUIController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

Issue 1009953002: Integrate ManagePasswordsState into ManagePasswordsUIController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: last comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_never_save_view_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

index a3b3ff142714d14b15f2cdea854845ec9471cfb0..fd1a36b7a482afb83f3e0d7c3a0cc1453bfa8839 100644

--- a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

@@ -53,7 +53,7 @@ using namespace password_manager::mac::ui;

}

- (void)onNeverForThisSiteClicked:(id)sender {

- if (model_->best_matches().empty()) {

+ if (model_->local_credentials().empty()) {

// Skip confirmation if there are no existing passwords for this site.

model_->OnNeverForThisSiteClicked();

[delegate_ viewShouldDismiss];