chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_account_chooser_view_controller.mm - Issue 1009953002: Integrate ManagePasswordsState into ManagePasswordsUIController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_account_chooser_view_controller.mm

Issue 1009953002: Integrate ManagePasswordsState into ManagePasswordsUIController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: last comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/account_chooser_infobar_delegate_android.cc ('k') | chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_account_chooser_view_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_account_chooser_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_account_chooser_view_controller.mm b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_account_chooser_view_controller.mm

index a4085e97aab0e46696e93b3ea0120ed0e1b03ff1..89eb76748bbccd5648a2d7a66c7b975c30e3731b 100644

--- a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_account_chooser_view_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_account_chooser_view_controller.mm

@@ -221,7 +221,7 @@

+ (NSArray*)credentialItemsForModel:(ManagePasswordsBubbleModel*)model

delegate:(id<CredentialItemDelegate>)delegate {

base::scoped_nsobject<NSMutableArray> items([[NSMutableArray alloc] init]);

- for (auto form : model->local_pending_credentials()) {

+ for (auto form : model->local_credentials()) {

base::scoped_nsobject<CredentialItemView> item([[CredentialItemView alloc]

initWithPasswordForm:*form

credentialType:password_manager::CredentialType::

@@ -229,7 +229,7 @@

delegate:delegate]);

[items addObject:item];

}

- for (auto form : model->federated_pending_credentials()) {

+ for (auto form : model->federated_credentials()) {

base::scoped_nsobject<CredentialItemView> item([[CredentialItemView alloc]

initWithPasswordForm:*form

credentialType:password_manager::CredentialType::