[1/8] Prepare Pepper for async output protection configuration

Prepare Pepper for async output protection configuration

Ozone/Freon needs to perform output protection asynchronous. This
changes the DisplayConfigurator entry points to take a callback and
changes the way Pepper calls into DisplayConfigurator.

BUG=442317
Committed: https://crrev.com/ccdb10a7a381fdcfcca54d98cd358b1562538af5
Cr-Commit-Position: refs/heads/master@{#326048}

[dnicoara, 2015-03-26 17:46:42]

dnicoara@chromium.org changed reviewers:
+ oshima@chromium.org

[oshima, 2015-04-02 16:00:51]

I'm not familiar with content protection itself. Just reviewing the style and
nits. lgtm.

https://codereview.chromium.org/1009943006/diff/1/ui/display/chromeos/display...
File ui/display/chromeos/display_configurator.h (right):

https://codereview.chromium.org/1009943006/diff/1/ui/display/chromeos/display...
ui/display/chromeos/display_configurator.h:52: uint32_t /* protection_mask */)>
It may be better to define struct instead of using native types.

[dnicoara, 2015-04-14 20:15:42]

dnicoara@chromium.org changed reviewers:
+ dmichael@chromium.org

[dnicoara, 2015-04-14 20:15:43]

+ dmichael@ for chrome/browser/renderer_host/pepper/*

As background, on Ozone/Freon, display configuration happens asynchronously.
This patch lays down the ground work for the asynchronous interface between
DisplayConfigurator and Pepper. I have a few other changes (all numbered in a
series) that change the internals of DisplayConfigurator to support asynchronous
content protection requests. Feel free to look over the other patches and let me
know if I can provide more details.

As for testing, I've made sure the display_unittests pass and did basic testing
with a ChromeOS ARM device and protected content to verify the changes.

https://codereview.chromium.org/1009943006/diff/1/ui/display/chromeos/display...
File ui/display/chromeos/display_configurator.h (right):

https://codereview.chromium.org/1009943006/diff/1/ui/display/chromeos/display...
ui/display/chromeos/display_configurator.h:52: uint32_t /* protection_mask */)>
On 2015/04/02 16:00:51, oshima (OOO Apr 13 - 14) wrote:
> It may be better to define struct instead of using native types.

Done.

[dmichael (off chromium), 2015-04-14 20:25:48]

dmichael@chromium.org changed reviewers:
+ raymes@chromium.org

[dmichael (off chromium), 2015-04-14 20:25:49]

I no longer work on Chromium. raymes, can you take it? Or see if bbudge has
time?

[dnicoara, 2015-04-17 21:04:06]

ping ... raymes@ could you please take a look?

[raymes, 2015-04-20 01:12:45]

Sorry I've been busy with some other reviews :) I don't have much context here
so I might need to find out a little more. I see 1/8 in the CL title. How much
change will there be on the pepper side? What changes need to be made?

Thanks!
Raymes

[dnicoara, 2015-04-20 13:54:08]

On 2015/04/20 01:12:45, raymes wrote:
> Sorry I've been busy with some other reviews :) I don't have much context here
> so I might need to find out a little more. I see 1/8 in the CL title. How much
> change will there be on the pepper side? What changes need to be made?
> 
> Thanks!
> Raymes

This is the only Pepper related change since the calls to
PepperOutputProtectionMessageFilter are already done asynchronously (makes it
easier for me :-). I've written these changes as a series from the display
configuration perspective and that's where the bulk of the changes are made.

The reason for the transition is because on Ozone/Freon display configuration
(and content protection) needs to be done asynchronously since all operations
are performed in the GPU process.

Feel free to browse the display configuration changes and ping me for more
details. I'm happy to provide more details.

[raymes, 2015-04-21 02:40:06]

lgtm with nits

https://codereview.chromium.org/1009943006/diff/20001/chrome/browser/renderer...
File
chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.cc
(right):

https://codereview.chromium.org/1009943006/diff/20001/chrome/browser/renderer...
chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.cc:108:
const EnableProtectionCallback& callback);
nit: since these are not message handlers I think it makes more sense just to
call them:
QueryStatus
EnableProtection

https://codereview.chromium.org/1009943006/diff/20001/chrome/browser/renderer...
chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.cc:117:
bool success);
and then call these:
QueryStatusComplete
EnableProtectionComplete

https://codereview.chromium.org/1009943006/diff/20001/chrome/browser/renderer...
File
chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.h
(right):

https://codereview.chromium.org/1009943006/diff/20001/chrome/browser/renderer...
chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.h:48:
void OnQueryStatusCallback(ppapi::host::ReplyMessageContext reply_context,
nit: perhaps call this QueryStatusComplete or QueryStatusCallback

https://codereview.chromium.org/1009943006/diff/20001/chrome/browser/renderer...
chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.h:53:
void OnEnableProtectionCallback(
nit: perhaps call this EnableProtectionComplete or EnableProtectionCallback

[raymes, 2015-04-21 02:40:17]

and thanks for the explanation! :)

[dnicoara, 2015-04-21 13:41:42]

Thank you!

https://codereview.chromium.org/1009943006/diff/20001/chrome/browser/renderer...
File
chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.cc
(right):

https://codereview.chromium.org/1009943006/diff/20001/chrome/browser/renderer...
chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.cc:108:
const EnableProtectionCallback& callback);
On 2015/04/21 02:40:05, raymes wrote:
> nit: since these are not message handlers I think it makes more sense just to
> call them:
> QueryStatus
> EnableProtection

Done.

https://codereview.chromium.org/1009943006/diff/20001/chrome/browser/renderer...
chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.cc:117:
bool success);
On 2015/04/21 02:40:05, raymes wrote:
> and then call these:
> QueryStatusComplete
> EnableProtectionComplete

Done.

https://codereview.chromium.org/1009943006/diff/20001/chrome/browser/renderer...
File
chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.h
(right):

https://codereview.chromium.org/1009943006/diff/20001/chrome/browser/renderer...
chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.h:48:
void OnQueryStatusCallback(ppapi::host::ReplyMessageContext reply_context,
On 2015/04/21 02:40:05, raymes wrote:
> nit: perhaps call this QueryStatusComplete or QueryStatusCallback

Done.

https://codereview.chromium.org/1009943006/diff/20001/chrome/browser/renderer...
chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.h:53:
void OnEnableProtectionCallback(
On 2015/04/21 02:40:05, raymes wrote:
> nit: perhaps call this EnableProtectionComplete or EnableProtectionCallback

Done.

[dnicoara, 2015-04-21 16:07:53]

The CQ bit was checked by dnicoara@chromium.org

[dnicoara, 2015-04-21 16:07:53]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/1009943006/#ps40001
(title: "Renames")

[commit-bot: I haz the power, 2015-04-21 16:08:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1009943006/40001

[commit-bot: I haz the power, 2015-04-21 16:25:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-21 16:26:52]

Patchset 3 (id:??) landed as
https://crrev.com/ccdb10a7a381fdcfcca54d98cd358b1562538af5
Cr-Commit-Position: refs/heads/master@{#326048}