Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1009933002: Bugfix in hydrogen GVN. (Closed)

Created:
5 years, 9 months ago by Igor Sheludko
Modified:
5 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Bugfix in hydrogen GVN. BUG=chromium:467481 LOG=Y Committed: https://crrev.com/ddfca2b06992b3f82dfdc89e468ddc518f18396a Cr-Commit-Position: refs/heads/master@{#27223}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Spurious change in the test removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M src/hydrogen.cc View 1 chunk +0 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-467481.js View 1 1 chunk +14 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Igor Sheludko
PTAL
5 years, 9 months ago (2015-03-16 13:12:24 UTC) #2
Jakob Kummerow
LGTM with nit. https://codereview.chromium.org/1009933002/diff/1/test/mjsunit/regress/regress-467481.js File test/mjsunit/regress/regress-467481.js (right): https://codereview.chromium.org/1009933002/diff/1/test/mjsunit/regress/regress-467481.js#newcode8 test/mjsunit/regress/regress-467481.js:8: for (var i = 0; i ...
5 years, 9 months ago (2015-03-16 13:15:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009933002/20001
5 years, 9 months ago (2015-03-16 13:18:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 13:46:14 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 13:46:27 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ddfca2b06992b3f82dfdc89e468ddc518f18396a
Cr-Commit-Position: refs/heads/master@{#27223}

Powered by Google App Engine
This is Rietveld 408576698