Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: src/frames-inl.h

Issue 1009903002: Revert of Remove kind field from StackHandler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/frames.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames-inl.h
diff --git a/src/frames-inl.h b/src/frames-inl.h
index 014c3444a35a549cdda6d2a7ee826e25d5909770..221b0069782b09951c618107c5fb270e7ada4f28 100644
--- a/src/frames-inl.h
+++ b/src/frames-inl.h
@@ -61,15 +61,36 @@
}
+inline bool StackHandler::is_js_entry() const {
+ return kind() == JS_ENTRY;
+}
+
+
+inline bool StackHandler::is_catch() const {
+ return kind() == CATCH;
+}
+
+
+inline bool StackHandler::is_finally() const {
+ return kind() == FINALLY;
+}
+
+
inline Context* StackHandler::context() const {
const int offset = StackHandlerConstants::kContextOffset;
return Context::cast(Memory::Object_at(address() + offset));
}
-inline int StackHandler::index() const {
+inline StackHandler::Kind StackHandler::kind() const {
const int offset = StackHandlerConstants::kStateIntOffset;
- return Memory::int_at(address() + offset);
+ return KindField::decode(Memory::unsigned_at(address() + offset));
+}
+
+
+inline unsigned StackHandler::index() const {
+ const int offset = StackHandlerConstants::kStateIntOffset;
+ return IndexField::decode(Memory::unsigned_at(address() + offset));
}
« no previous file with comments | « src/frames.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698