Issue 1009883002: Fix unresolved gn dependencies when enable_configuration_policy=false

Issue 1009883002: Fix unresolved gn dependencies when enable_configuration_policy=false (Closed)

Created:
5 years, 9 months ago by Tomasz Moniuszko

Modified:
5 years, 8 months ago

Reviewers:
brettw, weitao, dcaiafa

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix unresolved gn dependencies when enable_configuration_policy=false BUG= Committed: https://crrev.com/17efc23db9ac5f3cf9e329e500b56af56652293a Cr-Commit-Position: refs/heads/master@{#323206}

Created: 5 years, 8 months ago

		Unified diffs	Side-by-side diffs	Stats (+12 lines, -3 lines)
	M	remoting/BUILD.gn	View	2 chunks	+4 lines, -1 line	0 comments
	M	remoting/host/BUILD.gn	View	4 chunks	+8 lines, -2 lines	0 comments

Total messages: 10 (4 generated)

brettw

Did you run these files through "gn format"? I thought the single-ement += would tend ...

5 years, 8 months ago (2015-03-31 18:14:37 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009883002/20001

5 years, 8 months ago (2015-04-01 08:34:00 UTC) #8

commit-bot: I haz the power

5 years, 8 months ago (2015-04-01 10:17:44 UTC) #10

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/17efc23db9ac5f3cf9e329e500b56af56652293a
Cr-Commit-Position: refs/heads/master@{#323206}