Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 1009853002: Modify AX AriaGrabbed test and enable it. (Closed)

Created:
5 years, 9 months ago by je_julie(Not used)
Modified:
5 years, 9 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify AX AriaGrabbed test and enable it. This patch makes AccessibilityAriaGrabbed use data URI scheme for image and adds width and height attributes to image tag in order to avoid flaky situation. BUG=453485 R=dmazzoni Committed: https://crrev.com/f78be2afbe73ec8620cdb404ac34e1b4eafb125e Cr-Commit-Position: refs/heads/master@{#321306}

Patch Set 1 #

Patch Set 2 : Add width and height attributes #

Total comments: 2

Patch Set 3 : Add alt #

Total comments: 2

Patch Set 4 : Remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/aria/aria-grabbed.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/aria/aria-grabbed-expected-android.txt View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M content/test/data/accessibility/aria/aria-grabbed-expected-mac.txt View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/aria/aria-grabbed-expected-win.txt View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
D content/test/data/accessibility/aria/blue.png View Binary file 0 comments Download

Messages

Total messages: 11 (2 generated)
je_julie(Not used)
Hi Dominic, I investigated the possibility to reproduce the flaky situation. 1) Failed to load ...
5 years, 9 months ago (2015-03-17 04:06:50 UTC) #2
dmazzoni
lgtm This solution seems fine. Since none of this has anything to do with aria-grabbed ...
5 years, 9 months ago (2015-03-17 05:40:57 UTC) #3
je_julie(Not used)
Thanks for your comment. I added alt for image on test and update test results. ...
5 years, 9 months ago (2015-03-17 23:27:36 UTC) #4
dmazzoni
lgtm https://codereview.chromium.org/1009853002/diff/40001/content/test/data/accessibility/aria/aria-grabbed-expected-android.txt File content/test/data/accessibility/aria/aria-grabbed-expected-android.txt (right): https://codereview.chromium.org/1009853002/diff/40001/content/test/data/accessibility/aria/aria-grabbed-expected-android.txt#newcode15 content/test/data/accessibility/aria/aria-grabbed-expected-android.txt:15: <-- End-of-file --> I don't think you want ...
5 years, 9 months ago (2015-03-18 15:24:30 UTC) #5
je_julie(Not used)
Hi Dominic, PTAL. Thanks. https://codereview.chromium.org/1009853002/diff/40001/content/test/data/accessibility/aria/aria-grabbed-expected-android.txt File content/test/data/accessibility/aria/aria-grabbed-expected-android.txt (right): https://codereview.chromium.org/1009853002/diff/40001/content/test/data/accessibility/aria/aria-grabbed-expected-android.txt#newcode15 content/test/data/accessibility/aria/aria-grabbed-expected-android.txt:15: <-- End-of-file --> On 2015/03/18 ...
5 years, 9 months ago (2015-03-19 04:18:10 UTC) #6
dmazzoni
lgtm
5 years, 9 months ago (2015-03-19 04:18:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009853002/60001
5 years, 9 months ago (2015-03-19 04:18:57 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-19 06:20:10 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 06:21:14 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f78be2afbe73ec8620cdb404ac34e1b4eafb125e
Cr-Commit-Position: refs/heads/master@{#321306}

Powered by Google App Engine
This is Rietveld 408576698