Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1635)

Unified Diff: chrome/browser/about_flags.cc

Issue 1009673002: Remove enhanced bookmarks sync experiment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: . Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 0fa370cfca9ff6460ad5ec3d83034d6d5cadf7af..54a7c2b69cc6ea4b4c3af33a0a74b1f8253affa5 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -18,7 +18,6 @@
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "cc/base/switches.h"
-#include "chrome/browser/bookmarks/enhanced_bookmarks_features.h"
#include "chrome/browser/flags_storage.h"
#include "chrome/common/chrome_content_client.h"
#include "chrome/common/chrome_switches.h"
@@ -1647,20 +1646,6 @@ const Experiment kExperiments[] = {
switches::kEnhancedBookmarksExperiment, "1",
switches::kEnhancedBookmarksExperiment, "0")
},
- {
- "manual-enhanced-bookmarks",
- IDS_FLAGS_ENABLE_ENHANCED_BOOKMARKS_NAME,
- IDS_FLAGS_ENABLE_ENHANCED_BOOKMARKS_DESCRIPTION,
- kOsDesktop | kOsAndroid,
- SINGLE_VALUE_TYPE(switches::kManualEnhancedBookmarks)
- },
- {
- "manual-enhanced-bookmarks-optout",
- IDS_FLAGS_ENABLE_ENHANCED_BOOKMARKS_NAME,
- IDS_FLAGS_ENABLE_ENHANCED_BOOKMARKS_DESCRIPTION,
- kOsDesktop | kOsAndroid,
- SINGLE_VALUE_TYPE(switches::kManualEnhancedBookmarksOptout)
- },
#if defined(OS_ANDROID)
{
"enable-zero-suggest-experiment",
@@ -2330,12 +2315,6 @@ void GetSanitizedEnabledFlags(
bool SkipConditionalExperiment(const Experiment& experiment,
FlagsStorage* flags_storage) {
- if ((experiment.internal_name == std::string("manual-enhanced-bookmarks")) ||
- (experiment.internal_name ==
- std::string("manual-enhanced-bookmarks-optout"))) {
- return true;
- }
-
#if defined(OS_ANDROID) || defined(ENABLE_DATA_REDUCTION_PROXY_DEBUGGING)
chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();
#endif
@@ -2688,14 +2667,6 @@ void FlagsState::ConvertFlagsToSwitches(FlagsStorage* flags_storage,
continue;
}
-#if defined(OS_CHROMEOS)
- // On Chrome OS setting command line flag may make browser to restart on
- // user login. As this flag eventually will be set to a significant number
- // of users skip manual-enhanced-bookmarks to avoid restart.
- if (experiment_name == "manual-enhanced-bookmarks")
- continue;
-#endif
-
const std::pair<std::string, std::string>&
switch_and_value_pair = name_to_switch_it->second;

Powered by Google App Engine
This is Rietveld 408576698