chrome/browser/enhanced_bookmarks/android/enhanced_bookmark_tab_helper.cc - Issue 1009673002: Remove enhanced bookmarks sync experiment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/enhanced_bookmarks/android/enhanced_bookmark_tab_helper.cc

Issue 1009673002: Remove enhanced bookmarks sync experiment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/bookmarks/enhanced_bookmarks_features.cc ('K') | « chrome/browser/chrome_browser_main_android.cc ('k') | chrome/browser/extensions/external_component_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/enhanced_bookmarks/android/enhanced_bookmark_tab_helper.cc

diff --git a/chrome/browser/enhanced_bookmarks/android/enhanced_bookmark_tab_helper.cc b/chrome/browser/enhanced_bookmarks/android/enhanced_bookmark_tab_helper.cc

index 1b5675b952b9a39017f1e80ef47e9559700d1064..0fb5e58c4dea113d53cd3480fa0221b5b7a2934f 100644

--- a/chrome/browser/enhanced_bookmarks/android/enhanced_bookmark_tab_helper.cc

+++ b/chrome/browser/enhanced_bookmarks/android/enhanced_bookmark_tab_helper.cc

@@ -22,16 +22,13 @@ void EnhancedBookmarkTabHelper::DocumentOnLoadCompletedInMainFrame() {

if (profile->IsOffTheRecord())

return;

- bool is_enhanced_bookmarks_enabled =

- IsEnhancedBookmarksEnabled(profile->GetPrefs());

- if (!is_enhanced_bookmarks_enabled)

+ if (!IsEnhancedBookmarksEnabled())

return;

BookmarkImageServiceAndroid* storage =

static_cast<BookmarkImageServiceAndroid*>(

BookmarkImageServiceFactory::GetForBrowserContext(profile));

- storage->FinishSuccessfulPageLoadForTab(web_contents(),

- is_enhanced_bookmarks_enabled);

+ storage->FinishSuccessfulPageLoadForTab(web_contents(), true);

}

EnhancedBookmarkTabHelper::EnhancedBookmarkTabHelper(