Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: sync/internal_api/sync_manager_impl.cc

Issue 1009673002: Remove enhanced bookmarks sync experiment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/internal_api/sync_manager_impl.h" 5 #include "sync/internal_api/sync_manager_impl.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/base64.h" 9 #include "base/base64.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 952 matching lines...) Expand 10 before | Expand all | Expand 10 after
963 if (pre_commit_update_avoidance_node.InitByClientTagLookup( 963 if (pre_commit_update_avoidance_node.InitByClientTagLookup(
964 syncer::EXPERIMENTS, 964 syncer::EXPERIMENTS,
965 syncer::kPreCommitUpdateAvoidanceTag) == BaseNode::INIT_OK) { 965 syncer::kPreCommitUpdateAvoidanceTag) == BaseNode::INIT_OK) {
966 session_context_->set_server_enabled_pre_commit_update_avoidance( 966 session_context_->set_server_enabled_pre_commit_update_avoidance(
967 pre_commit_update_avoidance_node.GetExperimentsSpecifics(). 967 pre_commit_update_avoidance_node.GetExperimentsSpecifics().
968 pre_commit_update_avoidance().enabled()); 968 pre_commit_update_avoidance().enabled());
969 // We don't bother setting found_experiment. The frontend doesn't need to 969 // We don't bother setting found_experiment. The frontend doesn't need to
970 // know about this. 970 // know about this.
971 } 971 }
972 972
973 ReadNode enhanced_bookmarks_node(&trans);
974 if (enhanced_bookmarks_node.InitByClientTagLookup(
975 syncer::EXPERIMENTS, syncer::kEnhancedBookmarksTag) ==
976 BaseNode::INIT_OK &&
977 enhanced_bookmarks_node.GetExperimentsSpecifics()
978 .has_enhanced_bookmarks()) {
979 const sync_pb::EnhancedBookmarksFlags& enhanced_bookmarks =
980 enhanced_bookmarks_node.GetExperimentsSpecifics().enhanced_bookmarks();
981 if (enhanced_bookmarks.has_enabled())
982 experiments->enhanced_bookmarks_enabled = enhanced_bookmarks.enabled();
983 if (enhanced_bookmarks.has_extension_id()) {
984 experiments->enhanced_bookmarks_ext_id =
985 enhanced_bookmarks.extension_id();
986 }
987 found_experiment = true;
988 }
989
990 ReadNode gcm_invalidations_node(&trans); 973 ReadNode gcm_invalidations_node(&trans);
991 if (gcm_invalidations_node.InitByClientTagLookup( 974 if (gcm_invalidations_node.InitByClientTagLookup(
992 syncer::EXPERIMENTS, syncer::kGCMInvalidationsTag) == 975 syncer::EXPERIMENTS, syncer::kGCMInvalidationsTag) ==
993 BaseNode::INIT_OK) { 976 BaseNode::INIT_OK) {
994 const sync_pb::GcmInvalidationsFlags& gcm_invalidations = 977 const sync_pb::GcmInvalidationsFlags& gcm_invalidations =
995 gcm_invalidations_node.GetExperimentsSpecifics().gcm_invalidations(); 978 gcm_invalidations_node.GetExperimentsSpecifics().gcm_invalidations();
996 if (gcm_invalidations.has_enabled()) { 979 if (gcm_invalidations.has_enabled()) {
997 experiments->gcm_invalidations_enabled = gcm_invalidations.enabled(); 980 experiments->gcm_invalidations_enabled = gcm_invalidations.enabled();
998 found_experiment = true; 981 found_experiment = true;
999 } 982 }
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
1040 bool SyncManagerImpl::HasDirectoryTypeDebugInfoObserver( 1023 bool SyncManagerImpl::HasDirectoryTypeDebugInfoObserver(
1041 syncer::TypeDebugInfoObserver* observer) { 1024 syncer::TypeDebugInfoObserver* observer) {
1042 return model_type_registry_->HasDirectoryTypeDebugInfoObserver(observer); 1025 return model_type_registry_->HasDirectoryTypeDebugInfoObserver(observer);
1043 } 1026 }
1044 1027
1045 void SyncManagerImpl::RequestEmitDebugInfo() { 1028 void SyncManagerImpl::RequestEmitDebugInfo() {
1046 model_type_registry_->RequestEmitDebugInfo(); 1029 model_type_registry_->RequestEmitDebugInfo();
1047 } 1030 }
1048 1031
1049 } // namespace syncer 1032 } // namespace syncer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698