Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1009643002: [Cast] Add back ignored width/height in RtpPayloadParams IDL for Chrome 43. (Closed)

Created:
5 years, 9 months ago by miu
Modified:
5 years, 9 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast] Add back ignored width/height in RtpPayloadParams IDL for Chrome 43. A recent change (https://codereview.chromium.org/973753002/) removed the width/height properties from the IDL, but the Google Cast Extension needs them to be present until a patch rolls out to all Chrome Canary/Dev/Beta users. BUG=466357 TBR=finnur@chromium.org Committed: https://crrev.com/5ba8aa856919269a1a079c376d70480da0c2fc23 Cr-Commit-Position: refs/heads/master@{#320634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/common/extensions/api/cast_streaming_rtp_stream.idl View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
miu
finnur: PTAL. Bug describes issue in more detail. tl;dr: Temporarily putting two properties back in ...
5 years, 9 months ago (2015-03-13 22:39:47 UTC) #2
miu
On 2015/03/13 22:39:47, miu wrote: > finnur: PTAL. Bug describes issue in more detail. tl;dr: ...
5 years, 9 months ago (2015-03-14 01:33:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009643002/1
5 years, 9 months ago (2015-03-14 01:34:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-14 02:23:24 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5ba8aa856919269a1a079c376d70480da0c2fc23 Cr-Commit-Position: refs/heads/master@{#320634}
5 years, 9 months ago (2015-03-14 02:24:29 UTC) #7
Finnur
LGTM, especially once the properties are removed for good. :)
5 years, 9 months ago (2015-03-16 15:26:55 UTC) #8
miu
5 years, 4 months ago (2015-08-02 00:58:25 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1267073004/ by miu@chromium.org.

The reason for reverting is: As discussed in bug 466357, the plan was to revert
this patchset for Chrome 44 and later.  These fields will be gone starting in
Chrome 46, assuming this lands within the next couple weeks..

Powered by Google App Engine
This is Rietveld 408576698