Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1009633002: handler/mac: Support the in-Chromium component=shared_library (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org, Scott Hess - ex-Googler
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

handler/mac: Support the in-Chromium component=shared_library configuration. When depending on shared libraries such as libbase.dylib, crashpad_handler must have an LC_RPATH pointing to the out/{Debug,Release} directory relative to its home deep within Chromium.app. BUG=chromium:466964 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/1d022a86db566613c11ff03ad6e791f9c01ffe88

Patch Set 1 #

Patch Set 2 : Call out libbase.dylib by name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M handler/handler.gyp View 1 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-13 22:16:26 UTC) #2
Robert Sesek
LGTM. Everybody's favorite build.
5 years, 9 months ago (2015-03-13 22:22:43 UTC) #3
Mark Mentovai
5 years, 9 months ago (2015-03-13 22:23:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1d022a86db566613c11ff03ad6e791f9c01ffe88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698