content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc - Issue 100963005: [Pepper] Handle plugin crash on QuotaReservation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc

Issue 100963005: [Pepper] Handle plugin crash on QuotaReservation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: +comment Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/pepper/pepper_file_io_host.cc ('k') | content/browser/renderer_host/pepper/quota_reservation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc

diff --git a/content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc b/content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc

index 2bc00423d7128975470d13cac3101f9f09878f61..4b13f43e456ee4ea4266c1fe92295c791c060455 100644

--- a/content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc

+++ b/content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc

@@ -64,6 +64,14 @@ PepperFileSystemBrowserHost::PepperFileSystemBrowserHost(BrowserPpapiHost* host,

}

PepperFileSystemBrowserHost::~PepperFileSystemBrowserHost() {

+ // If |files_| is not empty, the plugin failed to close some files. It must

+ // have crashed.

+ if (!files_.empty()) {

+ file_system_context_->default_file_task_runner()->PostTask(

+ FROM_HERE,

+ base::Bind(&QuotaReservation::OnClientCrash, quota_reservation_));

+ }

// All FileRefs and FileIOs that reference us must have been destroyed. Cancel

// all pending file system operations.

if (file_system_operation_runner_)