[Pepper] Handle plugin crash on QuotaReservation

content/browser/renderer_host/pepper/pepper_file_system_browser_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/pepper/pepper_file_system_browser_host.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "content/browser/renderer_host/pepper/pepper_file_io_host.h"
 #include "content/browser/renderer_host/pepper/quota_reservation.h"
@@ skipping 45 matching lines @@
       browser_ppapi_host_(host),
       type_(type),
       called_open_(false),
       opened_(false),
       file_system_context_(NULL),
       reserved_quota_(0),
       reserving_quota_(false),
       weak_factory_(this) {
 }
 
 PepperFileSystemBrowserHost::~PepperFileSystemBrowserHost() {

[bbudge, 2014/01/07 14:48:18]

We have a way to detect plugin crashes in the renderer, and I thought
we would have to add that capability in the browser process too. Your
approach seems good to me though.

We probably need a comment here about the plugin crash. How about:
// If |files_| is not empty, the plugin failed to close some files. It must have
crashed.

[tzik, 2014/01/08 11:59:29]

Done.

+  if (!files_.empty()) {
+    file_system_context_->default_file_task_runner()->PostTask(
+        FROM_HERE,
+        base::Bind(&QuotaReservation::OnClientCrash, quota_reservation_));
+  }
+
   // All FileRefs and FileIOs that reference us must have been destroyed. Cancel
   // all pending file system operations.
   if (file_system_operation_runner_)
     file_system_operation_runner_->Shutdown();
 }
 
 void PepperFileSystemBrowserHost::OpenExisting(const GURL& root_url,
                                                const base::Closure& callback) {
   root_url_ = root_url;
   int render_process_id = 0;
@@ skipping 414 matching lines @@
     if (!IsAsciiAlpha(*it) && !IsAsciiDigit(*it) &&
         *it != '.' && *it != '_' && *it != '-') {
       LOG(WARNING) << "Failed to generate a plugin id.";
       return std::string();
     }
   }
   return output;
 }
 
 }  // namespace content