Use V8TRYCATCH_FOR_V8STRINGRESOURCE() macro instead of toCoreStringWithUndefinedOrNullCheck()

Source/bindings/v8/ScriptDebugServer.cpp

Index: Source/bindings/v8/ScriptDebugServer.cpp
diff --git a/Source/bindings/v8/ScriptDebugServer.cpp b/Source/bindings/v8/ScriptDebugServer.cpp
index ee11d9ef1322dc98d3d4ed43b2825d55dfe3c9df..01b84f0756bf7daeeebb80dbf050bef72cd67b3e 100644
--- a/Source/bindings/v8/ScriptDebugServer.cpp
+++ b/Source/bindings/v8/ScriptDebugServer.cpp
@@ -383,8 +383,10 @@ void ScriptDebugServer::handleProgramBreak(v8::Handle<v8::Object> executionState
     Vector<String> breakpointIds;
     if (!hitBreakpointNumbers.IsEmpty()) {
         breakpointIds.resize(hitBreakpointNumbers->Length());
-        for (size_t i = 0; i < hitBreakpointNumbers->Length(); i++)
-            breakpointIds[i] = toCoreStringWithUndefinedOrNullCheck(hitBreakpointNumbers->Get(i));
+        for (size_t i = 0; i < hitBreakpointNumbers->Length(); i++) {
+            V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>, hitBreakpointNumber, hitBreakpointNumbers->Get(i));

[pfeldman, 2013/12/12 16:41:41]

We need to make sure this comes in as string. vsevik@, yurys@, could you follow
up?

[yurys, 2013/12/12 20:04:43]

The array should actually contain numbers but we need them to be converted to
Stings to be later passed over the protocol. The conversion is done in
JavaScript at the moment which we can change and ASSERT that
hitBreakpointNumbers contains only numbers. These numbers can be converted to
Strings here using String::number(). This would make the code a way more clear
and let us avoid this scary mix of macros and templates. 

[Inactive, 2013/12/12 22:43:38]

Done.

+            breakpointIds[i] = hitBreakpointNumber;
+        }
     }
 
     m_executionState.set(m_isolate, executionState);