Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: Source/bindings/v8/ScriptDebugServer.cpp

Issue 100963003: Use V8TRYCATCH_FOR_V8STRINGRESOURCE() macro instead of toCoreStringWithUndefinedOrNullCheck() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take pfeldman's feedback into consideration Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/ScriptDebugServer.cpp
diff --git a/Source/bindings/v8/ScriptDebugServer.cpp b/Source/bindings/v8/ScriptDebugServer.cpp
index ee11d9ef1322dc98d3d4ed43b2825d55dfe3c9df..01b84f0756bf7daeeebb80dbf050bef72cd67b3e 100644
--- a/Source/bindings/v8/ScriptDebugServer.cpp
+++ b/Source/bindings/v8/ScriptDebugServer.cpp
@@ -383,8 +383,10 @@ void ScriptDebugServer::handleProgramBreak(v8::Handle<v8::Object> executionState
Vector<String> breakpointIds;
if (!hitBreakpointNumbers.IsEmpty()) {
breakpointIds.resize(hitBreakpointNumbers->Length());
- for (size_t i = 0; i < hitBreakpointNumbers->Length(); i++)
- breakpointIds[i] = toCoreStringWithUndefinedOrNullCheck(hitBreakpointNumbers->Get(i));
+ for (size_t i = 0; i < hitBreakpointNumbers->Length(); i++) {
+ V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>, hitBreakpointNumber, hitBreakpointNumbers->Get(i));
pfeldman 2013/12/12 16:41:41 We need to make sure this comes in as string. vsev
yurys 2013/12/12 20:04:43 The array should actually contain numbers but we n
Inactive 2013/12/12 22:43:38 Done.
+ breakpointIds[i] = hitBreakpointNumber;
+ }
}
m_executionState.set(m_isolate, executionState);

Powered by Google App Engine
This is Rietveld 408576698