Chromium Code Reviews| Index: Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp |
| diff --git a/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp b/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp |
| index cb545e6e3a3afe6fe68222b6fe08957684714df4..936d407a41bb35090590e894eb06a401edfd87d4 100644 |
| --- a/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp |
| +++ b/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp |
| @@ -365,7 +365,7 @@ void V8InjectedScriptHost::setFunctionVariableValueMethodCustom(const v8::Functi |
| { |
| v8::Handle<v8::Value> functionValue = info[0]; |
| int scopeIndex = info[1]->Int32Value(); |
| - String variableName = toCoreStringWithUndefinedOrNullCheck(info[2]); |
| + V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>, variableName, info[2]); |
|
pfeldman
2013/12/12 16:11:24
Same here, it is a string, see the call site.
|
| v8::Handle<v8::Value> newValue = info[3]; |
| InjectedScriptHost* host = V8InjectedScriptHost::toNative(info.Holder()); |
| @@ -428,9 +428,9 @@ void V8InjectedScriptHost::monitorFunctionMethodCustom(const v8::FunctionCallbac |
| if (!name->IsString() || !v8::Handle<v8::String>::Cast(name)->Length()) |
|
pfeldman
2013/12/12 16:11:24
Ditto - see this check.
|
| name = function->GetInferredName(); |
| } |
| - |
| + V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>, nameResource, name); |
| InjectedScriptHost* host = V8InjectedScriptHost::toNative(info.Holder()); |
| - host->monitorFunction(scriptId, lineNumber, columnNumber, toCoreStringWithUndefinedOrNullCheck(name)); |
| + host->monitorFunction(scriptId, lineNumber, columnNumber, nameResource); |
| } |
| void V8InjectedScriptHost::unmonitorFunctionMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info) |