LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments-expected.txt - Issue 100963003: Use V8TRYCATCH_FOR_V8STRINGRESOURCE() macro instead of toCoreStringWithUndefinedOrNullCheck()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments-expected.txt

Issue 100963003: Use V8TRYCATCH_FOR_V8STRINGRESOURCE() macro instead of toCoreStringWithUndefinedOrNullCheck() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take Yury's feedback into consideration Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 Checks that passing invalid strings to window.showModalDialog() is properly hand led.

	2

	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

	4

	5

	6 PASS newWindow = window.showModalDialog(nonConvertibleToString) threw exception Exception in toString().

	7 PASS newWindow is null

	8 PASS newWindow = window.showModalDialog('about:blank', '', nonConvertibleToStrin g) threw exception Exception in toString().

	9 PASS newWindow is null

	10 PASS successfullyParsed is true

	11

	12 TEST COMPLETE

	13

OLD	NEW

« no previous file with comments | « LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments.html ('k') | Source/bindings/v8/ScriptDebugServer.cpp » ('j') | no next file with comments »