Use V8TRYCATCH_FOR_V8STRINGRESOURCE() macro instead of toCoreStringWithUndefinedOrNullCheck()

Source/bindings/v8/ScriptDebugServer.cpp

 /*
  * Copyright (c) 2010-2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 365 matching lines @@
     if (isPaused())
         return;
 
     ScriptDebugListener* listener = getDebugListenerForContext(m_pausedContext);
     if (!listener)
         return;
 
     Vector<String> breakpointIds;
     if (!hitBreakpointNumbers.IsEmpty()) {
         breakpointIds.resize(hitBreakpointNumbers->Length());
-        for (size_t i = 0; i < hitBreakpointNumbers->Length(); i++)
-            breakpointIds[i] = toCoreStringWithUndefinedOrNullCheck(hitBreakpointNumbers->Get(i));
+        for (size_t i = 0; i < hitBreakpointNumbers->Length(); i++) {
+            V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullCheck>, hitBreakpointNumber, hitBreakpointNumbers->Get(i));

[pfeldman, 2013/12/12 16:41:41]

We need to make sure this comes in as string. vsevik@, yurys@, could you follow
up?

[yurys, 2013/12/12 20:04:43]

The array should actually contain numbers but we need them to be converted to
Stings to be later passed over the protocol. The conversion is done in
JavaScript at the moment which we can change and ASSERT that
hitBreakpointNumbers contains only numbers. These numbers can be converted to
Strings here using String::number(). This would make the code a way more clear
and let us avoid this scary mix of macros and templates. 

[Inactive, 2013/12/12 22:43:38]

Done.

+            breakpointIds[i] = hitBreakpointNumber;
+        }
     }
 
     m_executionState.set(m_isolate, executionState);
     ScriptState* currentCallFrameState = ScriptState::forContext(m_pausedContext);
     listener->didPause(currentCallFrameState, currentCallFrames(), ScriptValue(exception, currentCallFrameState->isolate()), breakpointIds);
 
     m_runningNestedMessageLoop = true;
     runMessageLoopOnPause(m_pausedContext);
     m_runningNestedMessageLoop = false;
 }
@@ skipping 219 matching lines @@
 {
     return PassOwnPtr<ScriptSourceCode>();
 }
 
 String ScriptDebugServer::preprocessEventListener(Frame*, const String& source, const String& url, const String& functionName)
 {
     return source;
 }
 
 } // namespace WebCore