Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: Source/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp

Issue 100963003: Use V8TRYCATCH_FOR_V8STRINGRESOURCE() macro instead of toCoreStringWithUndefinedOrNullCheck() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove toCoreString(v8::Handle<v8::Value> value) Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 19 matching lines...) Expand all
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "V8JavaScriptCallFrame.h" 32 #include "V8JavaScriptCallFrame.h"
33 33
34 #include "bindings/v8/V8Binding.h" 34 #include "bindings/v8/V8Binding.h"
35 35
36 namespace WebCore { 36 namespace WebCore {
37 37
38 void V8JavaScriptCallFrame::evaluateMethodCustom(const v8::FunctionCallbackInfo< v8::Value>& info) 38 void V8JavaScriptCallFrame::evaluateMethodCustom(const v8::FunctionCallbackInfo< v8::Value>& info)
39 { 39 {
40 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithUndefinedOrNullChe ck>, expression, info[0]);
Inactive 2013/12/12 15:59:26 For e.g. I understand that this is related to the
pfeldman 2013/12/12 16:11:24 This is only called from within InjectedScriptSour
40 JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toNative(info.Holder()); 41 JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toNative(info.Holder());
41 String expression = toCoreStringWithUndefinedOrNullCheck(info[0]);
42 v8SetReturnValue(info, impl->evaluate(expression)); 42 v8SetReturnValue(info, impl->evaluate(expression));
43 } 43 }
44 44
45 void V8JavaScriptCallFrame::restartMethodCustom(const v8::FunctionCallbackInfo<v 8::Value>& info) 45 void V8JavaScriptCallFrame::restartMethodCustom(const v8::FunctionCallbackInfo<v 8::Value>& info)
46 { 46 {
47 JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toNative(info.Holder()); 47 JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toNative(info.Holder());
48 v8SetReturnValue(info, impl->restart()); 48 v8SetReturnValue(info, impl->restart());
49 } 49 }
50 50
51 void V8JavaScriptCallFrame::scopeChainAttributeGetterCustom(const v8::PropertyCa llbackInfo<v8::Value>& info) 51 void V8JavaScriptCallFrame::scopeChainAttributeGetterCustom(const v8::PropertyCa llbackInfo<v8::Value>& info)
(...skipping 21 matching lines...) Expand all
73 v8SetReturnValue(info, impl->returnValue()); 73 v8SetReturnValue(info, impl->returnValue());
74 } 74 }
75 75
76 void V8JavaScriptCallFrame::typeAttributeGetterCustom(const v8::PropertyCallback Info<v8::Value>& info) 76 void V8JavaScriptCallFrame::typeAttributeGetterCustom(const v8::PropertyCallback Info<v8::Value>& info)
77 { 77 {
78 v8SetReturnValue(info, v8AtomicString(info.GetIsolate(), "function")); 78 v8SetReturnValue(info, v8AtomicString(info.GetIsolate(), "function"));
79 } 79 }
80 80
81 } // namespace WebCore 81 } // namespace WebCore
82 82
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698