[Toolbar UI Mac] Fix omnibox minimum width

[Toolbar UI Mac] Fix omnibox minimum width

The minimum width calculations weren't always taking effect with the omnibox
and the browser actions container. Refactor it a bit to make it:
a) more reliable (min width checked at every resize)
b) clearer (less confusing back and forth with using observer methods)

BUG=463905
Committed: https://crrev.com/027195d03b18a4724917ca51ffe323a1b4a52d68
Cr-Commit-Position: refs/heads/master@{#320784}

[Devlin, 2015-03-13 23:02:20]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org

[Devlin, 2015-03-13 23:02:21]

Avi, mind taking a look?

[Avi (use Gerrit), 2015-03-13 23:26:03]

https://codereview.chromium.org/1009613002/diff/1/chrome/browser/ui/cocoa/ext...
File chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h
(right):

https://codereview.chromium.org/1009613002/diff/1/chrome/browser/ui/cocoa/ext...
chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h:82: // The
size delegate, if any.
Document lifetime requirements and ownership semantics.

https://codereview.chromium.org/1009613002/diff/1/chrome/browser/ui/cocoa/ext...
File chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm
(right):

https://codereview.chromium.org/1009613002/diff/1/chrome/browser/ui/cocoa/ext...
chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm:200: width
= maxAllowedWidth;
std::min? (parallel to line 195)

https://codereview.chromium.org/1009613002/diff/1/chrome/browser/ui/cocoa/ext...
File
chrome/browser/ui/cocoa/extensions/browser_actions_container_view_unittest.mm
(right):

https://codereview.chromium.org/1009613002/diff/1/chrome/browser/ui/cocoa/ext...
chrome/browser/ui/cocoa/extensions/browser_actions_container_view_unittest.mm:22:
CGFloat GetMaxAllowedWidth() override { return kMaxAllowedWidthForTest; }
blank line before

[Devlin, 2015-03-14 00:03:15]

https://codereview.chromium.org/1009613002/diff/1/chrome/browser/ui/cocoa/ext...
File chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h
(right):

https://codereview.chromium.org/1009613002/diff/1/chrome/browser/ui/cocoa/ext...
chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h:82: // The
size delegate, if any.
On 2015/03/13 23:26:03, Avi wrote:
> Document lifetime requirements and ownership semantics.

Done.

https://codereview.chromium.org/1009613002/diff/1/chrome/browser/ui/cocoa/ext...
File chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm
(right):

https://codereview.chromium.org/1009613002/diff/1/chrome/browser/ui/cocoa/ext...
chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm:200: width
= maxAllowedWidth;
On 2015/03/13 23:26:03, Avi wrote:
> std::min? (parallel to line 195)

Done.

https://codereview.chromium.org/1009613002/diff/1/chrome/browser/ui/cocoa/ext...
File
chrome/browser/ui/cocoa/extensions/browser_actions_container_view_unittest.mm
(right):

https://codereview.chromium.org/1009613002/diff/1/chrome/browser/ui/cocoa/ext...
chrome/browser/ui/cocoa/extensions/browser_actions_container_view_unittest.mm:22:
CGFloat GetMaxAllowedWidth() override { return kMaxAllowedWidthForTest; }
On 2015/03/13 23:26:03, Avi wrote:
> blank line before

Done.

[Avi (use Gerrit), 2015-03-14 01:05:34]

lgtm

[Devlin, 2015-03-16 18:53:53]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-03-16 18:55:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1009613002/20001

[commit-bot: I haz the power, 2015-03-16 20:22:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-16 20:23:03]

Patchset 2 (id:??) landed as
https://crrev.com/027195d03b18a4724917ca51ffe323a1b4a52d68
Cr-Commit-Position: refs/heads/master@{#320784}

[pfeldman, 2015-03-17 09:41:56]

On 2015/03/16 20:23:03, I haz the power (commit-bot) wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/027195d03b18a4724917ca51ffe323a1b4a52d68
> Cr-Commit-Position: refs/heads/master@{#320784}

This breaks a layout test, I'm muting it and filing a bug for you:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec...

[Devlin, 2015-03-18 16:22:33]

On 2015/03/17 09:41:56, pfeldman wrote:
> On 2015/03/16 20:23:03, I haz the power (commit-bot) wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/027195d03b18a4724917ca51ffe323a1b4a52d68
> > Cr-Commit-Position: refs/heads/master@{#320784}
> 
> This breaks a layout test, I'm muting it and filing a bug for you:
> 
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec...

For the record, this CL wasn't the culprit (crbug.com/467871).

[Scott Hess - ex-Googler, 2015-03-23 16:26:35]

shess@chromium.org changed reviewers:
+ shess@chromium.org

[Scott Hess - ex-Googler, 2015-03-23 16:26:41]

https://codereview.chromium.org/1009613002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm
(right):

https://codereview.chromium.org/1009613002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/browser_actions_container_view.mm:174:
grippyPinned_ = NSWidth(containerFrame) == maxAllowedWidth;
Since these are floats this pattern may come back to bite if someday someone
throws ratios in somewhere, and could also bite WRT hidpi.  I'm not sure if
fuzzy matching would be better, since I don't know what grippyPinned_ really
means, but probably >= or <= would be safer.

Likewise for the == in the if() above, and the == in -resizeToWidth:animate: