extensions/browser/extension_host.cc - Issue 1009583004: Add UMA histograms and logging for bad IPC message handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_host.cc

Issue 1009583004: Add UMA histograms and logging for bad IPC message handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/render_process_host.h ('K') | « extensions/browser/blob_holder.cc ('k') | extensions/browser/guest_view/extension_options/extension_options_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_host.cc

diff --git a/extensions/browser/extension_host.cc b/extensions/browser/extension_host.cc

index 4ab887d29833ef007101edd27422c658477b7fdd..20758d7507154d97e7c195ac4bb883751ec548e4 100644

--- a/extensions/browser/extension_host.cc

+++ b/extensions/browser/extension_host.cc

@@ -19,6 +19,7 @@

#include "content/public/browser/render_widget_host_view.h"

#include "content/public/browser/site_instance.h"

#include "content/public/browser/web_contents.h"

+#include "extensions/browser/bad_message.h"

#include "extensions/browser/event_router.h"

#include "extensions/browser/extension_error.h"

#include "extensions/browser/extension_host_delegate.h"

@@ -365,7 +366,8 @@ void ExtensionHost::OnEventAck(int event_id) {

DCHECK(render_process_host());

LOG(ERROR) << "Killing renderer for extension " << extension_id() << " for "

<< "sending an EventAck message with a bad event id.";

- render_process_host()->ReceivedBadMessage();

+ bad_message::ReceivedBadMessage(render_process_host(),

+ bad_message::EH_BAD_EVENT_ID);

}