Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.cc

Issue 1009583004: Add UMA histograms and logging for bad IPC message handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: actions.xml claims to be pretty printed Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/extension_options/extension_options_guest.cc
diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.cc b/extensions/browser/guest_view/extension_options/extension_options_guest.cc
index 11e7062d8a5295fa66415051f5ab1bac10454449..07166066e692a070c0601e32524a73e735b8c80b 100644
--- a/extensions/browser/guest_view/extension_options/extension_options_guest.cc
+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.cc
@@ -4,7 +4,6 @@
#include "extensions/browser/guest_view/extension_options/extension_options_guest.h"
-#include "base/metrics/user_metrics.h"
#include "base/values.h"
#include "components/crx_file/id_util.h"
#include "content/public/browser/navigation_details.h"
@@ -13,6 +12,7 @@
#include "content/public/browser/web_contents.h"
#include "content/public/common/result_codes.h"
#include "extensions/browser/api/extensions_api_client.h"
+#include "extensions/browser/bad_message.h"
#include "extensions/browser/extension_function_dispatcher.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_web_contents_observer.h"
@@ -224,9 +224,8 @@ void ExtensionOptionsGuest::DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) {
if (attached() && (params.url.GetOrigin() != options_page_.GetOrigin())) {
- base::RecordAction(base::UserMetricsAction("BadMessageTerminate_EOG"));
- web_contents()->GetRenderProcessHost()->Shutdown(
- content::RESULT_CODE_KILLED_BAD_MESSAGE, false /* wait */);
+ bad_message::ReceivedBadMessage(web_contents()->GetRenderProcessHost(),
+ bad_message::EOG_BAD_ORIGIN);
}
}
« no previous file with comments | « extensions/browser/extension_host.cc ('k') | extensions/browser/guest_view/extension_view/extension_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698