Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: extensions/browser/bad_message.h

Issue 1009583004: Add UMA histograms and logging for bad IPC message handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review 1 Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/bad_message.h
diff --git a/extensions/browser/bad_message.h b/extensions/browser/bad_message.h
new file mode 100644
index 0000000000000000000000000000000000000000..66c79c6673a9e4fcd02b27ae95eb24dada011667
--- /dev/null
+++ b/extensions/browser/bad_message.h
@@ -0,0 +1,44 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_BROWSER_BAD_MESSAGE_H_
+#define EXTENSIONS_BROWSER_BAD_MESSAGE_H_
+
+namespace content {
+class RenderProcessHost;
+}
+
+namespace extensions {
+namespace bad_message {
+
+// The browser process often chooses to terminate a renderer if it receives
+// a bad IPC message. The reasons are tracked for metrics.
+//
+// See also content/browser/bad_message.h.
+//
+// NOTE: Do not remove or reorder elements in this list. Add new entries at the
+// end. Items may be renamed but do not change the values. We rely on the enum
+// values in histograms.
+enum BadMessageReason {
+ EOG_BAD_ORIGIN = 0,
+ EVG_BAD_ORIGIN,
+ BH_BLOB_NOT_OWNED,
+ EH_BAD_EVENT_ID,
+ // Please add new elements here. The naming convention is abbreviated class
+ // name (e.g. ExtensionHost becomes EH) plus a unique description of the
+ // reason.
+
Charlie Reis 2015/03/19 04:01:49 Same nit.
James Cook 2015/03/19 16:19:11 Done.
+ BAD_MESSAGE_MAX
+};
+
+// Called when the browser receives a bad IPC message from an extension process.
+// Logs the event, records a histogram metric for the |reason|, and terminates
+// the process for |host|.
+void ReceivedBadMessage(content::RenderProcessHost* host,
+ BadMessageReason reason);
+
+} // bad_message
+} // namespace extensions
+
+#endif // EXTENSIONS_BROWSER_BAD_MESSAGE_H_

Powered by Google App Engine
This is Rietveld 408576698