extensions/browser/guest_view/extension_options/extension_options_guest.cc - Issue 1009583004: Add UMA histograms and logging for bad IPC message handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.cc

Issue 1009583004: Add UMA histograms and logging for bad IPC message handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/bad_message.h ('K') | « extensions/browser/extension_host.cc ('k') | extensions/browser/guest_view/extension_view/extension_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/extension_options/extension_options_guest.cc

diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.cc b/extensions/browser/guest_view/extension_options/extension_options_guest.cc

index 11e7062d8a5295fa66415051f5ab1bac10454449..07166066e692a070c0601e32524a73e735b8c80b 100644

--- a/extensions/browser/guest_view/extension_options/extension_options_guest.cc

+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.cc

@@ -4,7 +4,6 @@

#include "extensions/browser/guest_view/extension_options/extension_options_guest.h"

-#include "base/metrics/user_metrics.h"

#include "base/values.h"

#include "components/crx_file/id_util.h"

#include "content/public/browser/navigation_details.h"

@@ -13,6 +12,7 @@

#include "content/public/browser/web_contents.h"

#include "content/public/common/result_codes.h"

#include "extensions/browser/api/extensions_api_client.h"

+#include "extensions/browser/bad_message.h"

#include "extensions/browser/extension_function_dispatcher.h"

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/extension_web_contents_observer.h"

@@ -224,9 +224,8 @@ void ExtensionOptionsGuest::DidNavigateMainFrame(

const content::LoadCommittedDetails& details,

const content::FrameNavigateParams& params) {

if (attached() && (params.url.GetOrigin() != options_page_.GetOrigin())) {

- base::RecordAction(base::UserMetricsAction("BadMessageTerminate_EOG"));

- web_contents()->GetRenderProcessHost()->Shutdown(

- content::RESULT_CODE_KILLED_BAD_MESSAGE, false /* wait */);

+ bad_message::ReceivedBadMessage(web_contents()->GetRenderProcessHost(),

+ bad_message::EOG_BAD_ORIGIN);

}