content/browser/browser_child_process_host_impl.cc - Issue 1009583004: Add UMA histograms and logging for bad IPC message handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_child_process_host_impl.cc

Issue 1009583004: Add UMA histograms and logging for bad IPC message handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix mac Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/bad_message.h ('K') | « content/browser/bad_message.cc ('k') | content/browser/frame_host/navigation_controller_impl.cc » ('j') | content/public/browser/render_process_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_child_process_host_impl.cc

diff --git a/content/browser/browser_child_process_host_impl.cc b/content/browser/browser_child_process_host_impl.cc

index 3245e2ba34abb86e143a7bc7d83a980de12e1532..6ace7de4aba1f452b409a7e5532d1ae14e4d4e14 100644

--- a/content/browser/browser_child_process_host_impl.cc

+++ b/content/browser/browser_child_process_host_impl.cc

@@ -256,6 +256,8 @@ void BrowserChildProcessHostImpl::OnBadMessageReceived(

switches::kDisableKillAfterBadIPC)) {

return;

}

+ LOG(ERROR) << "Terminating child process for bad IPC message of type "

+ << message.type();

child_process_->GetProcess().Terminate(RESULT_CODE_KILLED_BAD_MESSAGE, false);

Charlie Reis 2015/03/18 21:37:51 Would be nice if this one fit the model as well, b

}