content/browser/web_contents/web_contents_impl.cc - Issue 1009583004: Add UMA histograms and logging for bad IPC message handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1009583004: Add UMA histograms and logging for bad IPC message handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_process_host_impl.cc ('K') | « content/browser/service_worker/service_worker_version.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 977824c9a05b787b814e7a853d960748d64a8f37..7b7b8c30bf2cee94b8d2be3d907b602a4e4b89bb 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -62,6 +62,7 @@

#include "content/common/ssl_status_serialization.h"

#include "content/common/view_messages.h"

#include "content/public/browser/ax_event_notification_details.h"

+#include "content/public/browser/bad_message.h"

#include "content/public/browser/browser_context.h"

#include "content/public/browser/browser_plugin_guest_manager.h"

#include "content/public/browser/content_browser_client.h"

@@ -602,8 +603,8 @@ bool WebContentsImpl::OnMessageReceived(RenderViewHost* render_view_host,

bool WebContentsImpl::HasValidFrameSource() {

if (!render_frame_message_source_) {

DCHECK(render_view_message_source_);

- RecordAction(base::UserMetricsAction("BadMessageTerminate_WC"));

- GetRenderProcessHost()->ReceivedBadMessage();

+ GetRenderProcessHost()->ReceivedBadMessage(

+ BadMessage::WC_INVALID_FRAME_SOURCE);

return false;

}