content/browser/frame_host/navigation_controller_impl.cc - Issue 1009583004: Add UMA histograms and logging for bad IPC message handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 1009583004: Add UMA histograms and logging for bad IPC message handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_child_process_host_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/browser/renderer_host/render_process_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigation_controller_impl.cc

diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc

index 6610cb1202c04ab2360021ba4a1df4f4aba3f4ea..6ac51db0406185f26987617b799f931f34c580f0 100644

--- a/content/browser/frame_host/navigation_controller_impl.cc

+++ b/content/browser/frame_host/navigation_controller_impl.cc

@@ -25,6 +25,7 @@

#include "content/browser/site_instance_impl.h"

#include "content/common/frame_messages.h"

#include "content/common/view_messages.h"

+#include "content/public/browser/bad_message.h"

#include "content/public/browser/browser_context.h"

#include "content/public/browser/content_browser_client.h"

#include "content/public/browser/invalidate_type.h"

@@ -134,7 +135,7 @@ bool AreURLsInPageNavigation(const GURL& existing_url,

(prefs.allow_universal_access_from_file_urls &&

existing_url.SchemeIs(url::kFileScheme));

if (!is_same_origin && renderer_says_in_page)

- rfh->GetProcess()->ReceivedBadMessage();

+ rfh->GetProcess()->ReceivedBadMessage(BadMessage::NC_IN_PAGE_NAVIGATION);

return is_same_origin && renderer_says_in_page;

}