Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Issue 1009573003: [Password manager tests automation] Wait longer for SAVE/ASK (Closed)

Created:
5 years, 9 months ago by vabr (Chromium)
Modified:
5 years, 9 months ago
Reviewers:
battre
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password manager tests automation] Wait longer for SAVE/ASK When the tests determine, whether Chrome displayed a "save password" prompt appropriately (or saved automatically in the setting skipping the UI), it scrapes the password internals page for the corresponding ASK/SAVE message. There is a delay between a new page loads and this message appears. Currently the tests wait max. 3 seconds until giving up. That breaks often. This CL changes that to 15 seconds, curing some of the tests. Note that if the message is received earlier, the tests don't wait for the rest of the timeout, so this should not make the test duration unnecessarily longer. BUG=369521 R=battre@chromium.org Committed: https://crrev.com/395d6201294056a28f32c98b6cfdd741ddb0d527 Cr-Commit-Position: refs/heads/master@{#320708}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/test/data/password_manager/automated_tests/environment.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
vabr (Chromium)
Hi Dominic, PTAL. This might also be the source of the issues you observed at ...
5 years, 9 months ago (2015-03-13 19:16:37 UTC) #1
battre
lgtm
5 years, 9 months ago (2015-03-16 08:31:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009573003/1
5 years, 9 months ago (2015-03-16 09:06:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 11:33:27 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 11:34:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/395d6201294056a28f32c98b6cfdd741ddb0d527
Cr-Commit-Position: refs/heads/master@{#320708}

Powered by Google App Engine
This is Rietveld 408576698