Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1009543005: Revert "Roll ANGLE 524e3bde19..6bd5831261" (Closed)

Created:
5 years, 9 months ago by oshima
Modified:
5 years, 9 months ago
Reviewers:
Jamie Madill
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Roll ANGLE 524e3bde19..6bd5831261" Reason for revert: This is causing compilation error on chromiumos builds. bot/chrome_root/src/third_party/angle/src/common/debug.h:147:42: error: missing binary operator before token "(" chromeos-chrome-43.0.2337.0_alpha-r1: #elif defined(__clang__) && __has_feature(cxx_static_assert) see crbug.com/468139 for more detials. > Roll ANGLE 524e3bde19..6bd5831261 > > https://chromium.googlesource.com/angle/angle/+log/524e3bde19..6bd5831261 > > BUG=466735, 466704 > > Review URL: https://codereview.chromium.org/1011213002 > > Cr-Commit-Position: refs/heads/master@{#320988} BUG=466735, 466704, 468139 TBR=jmadill@chromium.org Committed: https://crrev.com/98f9a6bdb1110654e8c6eecc74aa437b8a6b89c1 Cr-Commit-Position: refs/heads/master@{#321055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
oshima
5 years, 9 months ago (2015-03-17 23:49:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009543005/1
5 years, 9 months ago (2015-03-17 23:50:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 02:19:19 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 02:20:25 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98f9a6bdb1110654e8c6eecc74aa437b8a6b89c1
Cr-Commit-Position: refs/heads/master@{#321055}

Powered by Google App Engine
This is Rietveld 408576698