Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: net/quic/test_tools/quic_test_packet_maker.cc

Issue 1009543004: Create a Perspective enum to use instead of a bool is_server to improve (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added NET_EXPORT_PRIVATE to fix compiler error Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/quic_sent_packet_manager_peer.cc ('k') | net/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/test_tools/quic_test_packet_maker.cc
diff --git a/net/quic/test_tools/quic_test_packet_maker.cc b/net/quic/test_tools/quic_test_packet_maker.cc
index ecdd6bf882cc71d757ec6acb0b8e70ca26c3306d..486c2f516a7e8af394c4d2aecbab303f6dc98146 100644
--- a/net/quic/test_tools/quic_test_packet_maker.cc
+++ b/net/quic/test_tools/quic_test_packet_maker.cc
@@ -82,7 +82,8 @@ scoped_ptr<QuicEncryptedPacket> QuicTestPacketMaker::MakeAckAndRstPacket(
QuicRstStreamFrame rst(stream_id, error_code, 0);
frames.push_back(QuicFrame(&rst));
- QuicFramer framer(SupportedVersions(version_), clock_->Now(), false);
+ QuicFramer framer(SupportedVersions(version_), clock_->Now(),
+ Perspective::IS_CLIENT);
scoped_ptr<QuicPacket> packet(
BuildUnsizedDataPacket(&framer, header, frames));
return scoped_ptr<QuicEncryptedPacket>(framer.EncryptPacket(
@@ -128,7 +129,8 @@ scoped_ptr<QuicEncryptedPacket> QuicTestPacketMaker::MakeAckPacket(
ack.received_packet_times.push_back(make_pair(i, clock_->Now()));
}
- QuicFramer framer(SupportedVersions(version_), clock_->Now(), false);
+ QuicFramer framer(SupportedVersions(version_), clock_->Now(),
+ Perspective::IS_CLIENT);
QuicFrames frames;
frames.push_back(QuicFrame(&ack));
@@ -234,7 +236,8 @@ SpdyHeaderBlock QuicTestPacketMaker::GetResponseHeaders(
scoped_ptr<QuicEncryptedPacket> QuicTestPacketMaker::MakePacket(
const QuicPacketHeader& header,
const QuicFrame& frame) {
- QuicFramer framer(SupportedVersions(version_), QuicTime::Zero(), false);
+ QuicFramer framer(SupportedVersions(version_), QuicTime::Zero(),
+ Perspective::IS_CLIENT);
QuicFrames frames;
frames.push_back(frame);
scoped_ptr<QuicPacket> packet(
« no previous file with comments | « net/quic/test_tools/quic_sent_packet_manager_peer.cc ('k') | net/quic/test_tools/quic_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698