Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: content/renderer/media/rtc_peer_connection_handler.cc

Issue 1009543003: Slight reduction in string copying for WebRTC stats. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_peer_connection_handler.cc
diff --git a/content/renderer/media/rtc_peer_connection_handler.cc b/content/renderer/media/rtc_peer_connection_handler.cc
index 57a7de3140834f1f60645008767691f6a5e787a2..20288bb9cfb0830e3330c32817f6a06e8078a789 100644
--- a/content/renderer/media/rtc_peer_connection_handler.cc
+++ b/content/renderer/media/rtc_peer_connection_handler.cc
@@ -406,10 +406,19 @@ class StatsResponse : public webrtc::StatsObserver {
int idx = response->addReport(blink::WebString::fromUTF8(report.id),
blink::WebString::fromUTF8(report.type),
report.timestamp);
+ blink::WebString name, value_str;
for (const auto& value : report.values) {
- response->addStatistic(idx,
- blink::WebString::fromUTF8(value.second->display_name()),
- blink::WebString::fromUTF8(value.second->ToString()));
+ const StatsReport::ValuePtr& v = value.second;
+ name = blink::WebString::fromUTF8(value.second->display_name());
+
+ if (v->type() == StatsReport::Value::kString)
+ value_str = blink::WebString::fromUTF8(v->string_val());
+ if (v->type() == StatsReport::Value::kStaticString)
+ value_str = blink::WebString::fromUTF8(v->static_string_val());
+ else
+ value_str = blink::WebString::fromUTF8(v->ToString());
+
+ response->addStatistic(idx, name, value_str);
}
}

Powered by Google App Engine
This is Rietveld 408576698