Add Segoe UI and its set of linked fonts to the font back list on Windows.

ui/gfx/render_text_harfbuzz.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/render_text_harfbuzz.h"
 
 #include <limits>
 
 #include "base/i18n/bidi_line_iterator.h"
 #include "base/i18n/break_iterator.h"
@@ skipping 1272 matching lines @@
       GetFallbackFontFamilies(primary_family);
 
 #if defined(OS_WIN)
   // Append fonts in the fallback list of the Uniscribe font.
   if (!uniscribe_family.empty()) {
     std::vector<std::string> uniscribe_fallbacks =
         GetFallbackFontFamilies(uniscribe_family);
     fallback_families.insert(fallback_families.end(),
         uniscribe_fallbacks.begin(), uniscribe_fallbacks.end());
   }
+
+  // Add Segoe UI and its associated linked fonts to the fallback font list to
+  // ensure that the fallback list covers the basic cases.
+  // http://crbug.com/467459. On some Windows configurations the default font
+  // could be a raster font like System, which would not give us a reasonable
+  // fallback font list.
+  std::vector<std::string> default_fallback_families =
+      GetFallbackFontFamilies("Segoe UI");

[msw, 2015/03/18 15:53:23]

(1) Why does the bug only occur with DirectWrite? (users claim that
--disable-directwrite-for-ui is a workaround, how does that mitigate the
issue?). (2) Why does/should this change affect GDI? (3) What happens here if
"Segoe UI" isn't installed? (it's not included with Windows XP by default,
afaict...) (4) Shouldn't we avoid duplicate fonts in the fallback list?
(especially if Segoe UI is already the default font, I think this will *double*
the number of shaping passes for runs that need fallback?). (5) Why don't we use
Tahoma or Microsoft Sans Serif (available on XP and additionally support Hebrew
and Thai characters, beyond Latin/Greek/Cyrillic).

I'm dubious that this is the correct change...

[scottmg, 2015/03/18 16:13:04]

It's definitely quite a mess. We did reproduce corrupted characters in GDI too,
so it's possible we're not reproing the same thing that users are seeing, it's
not clear.

Blink does this, which perhaps we need to consider doing:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

I didn't realize duplicating entries in the list was expensive. If there's no
missing glyphs (i.e. Segoe UI is already in the list and helps) then it won't
get here anyway, so maybe it it shouldn't matter in the common case. (?)

Tahoma might be a better choice. We only have reports from Win7 and Win8
currently where Segoe should be available.

[ananta, 2015/03/18 18:41:12]

The current approach of font fallback does not work on Windows XP anyways. We
use linked fonts which are based off this registry key
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows
NT\CurrentVersion\FontLink\SystemLink.

That key does not exist on Windows XP. 

That being said, as scottmg mentioned the bug does occur with GDI as well if the
system font is set to bitmap fonts like System. 

On a related note on a Windows 7 Korean installation the Microsoft Sans Seriff
font was not present in the list of linked fonts. 
Tahoma is there in the linked fonts for Segoe UI.

We do need a better way to achieve font fallback which makes me wonder why don't
we use skia's fallback logic. Would be better than duplicating the same code in
multiple places.

+  fallback_families.insert(fallback_families.end(),
+      default_fallback_families.begin(), default_fallback_families.end());
 #endif
 
   // Try shaping with the fallback fonts.
   for (const auto& family : fallback_families) {
     if (family == primary_family)
       continue;
 #if defined(OS_WIN)
     if (family == uniscribe_family)
       continue;
 #endif
@@ skipping 189 matching lines @@
   DCHECK(!update_layout_run_list_);
   DCHECK(!update_display_run_list_);
   return text_elided() ? display_run_list_.get() : &layout_run_list_;
 }
 
 const internal::TextRunList* RenderTextHarfBuzz::GetRunList() const {
   return const_cast<RenderTextHarfBuzz*>(this)->GetRunList();
 }
 
 }  // namespace gfx