Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 100953004: Add a UseCounter for HTMLHtmlElement.manifest (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
Reviewers:
abarth-chromium, ojan
CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Add a UseCounter for HTMLHtmlElement.manifest http://whatwg.org/html#attr-html-manifest The spec says "The manifest attribute only has an effect during the early stages of document load. Changing the attribute dynamically thus has no effect (and thus, no DOM API is provided for this attribute)." Added in <http://trac.webkit.org/changeset/66327>; and confirmed by Darin Adler to be unintentional. BUG=325420 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163170

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/frame/UseCounter.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLHtmlElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
philipj_slow
7 years ago (2013-12-03 20:21:45 UTC) #1
philipj_slow
Ojan, can you do this one as well, since the overflowchanged review depends on it?
7 years ago (2013-12-03 21:28:30 UTC) #2
abarth-chromium
lgtm
7 years ago (2013-12-03 22:26:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/100953004/20001
7 years ago (2013-12-03 22:26:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/100953004/20001
7 years ago (2013-12-04 07:25:57 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/Document.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-04 07:26:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/100953004/40001
7 years ago (2013-12-04 09:13:35 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=14477
7 years ago (2013-12-04 10:31:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/100953004/40001
7 years ago (2013-12-04 10:45:01 UTC) #9
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-04 11:10:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/100953004/50001
7 years ago (2013-12-04 11:48:35 UTC) #11
commit-bot: I haz the power
7 years ago (2013-12-04 13:14:10 UTC) #12
Message was sent while issue was closed.
Change committed as 163170

Powered by Google App Engine
This is Rietveld 408576698