Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7992)

Unified Diff: chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

Issue 1009453003: New metric to track usage of the new GAIA flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Document when the value is reported. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
index 9b0ed4859ea13ffd642c41902be4c0d014ee6122..11597974db702ddf38741102761e35b5027611d7 100644
--- a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
@@ -121,6 +121,11 @@ void RecordSAMLScrapingVerificationResultInHistogram(bool success) {
UMA_HISTOGRAM_BOOLEAN("ChromeOS.SAML.Scraping.VerificationResult", success);
}
+void RecordGAIAFlowTypeHistogram() {
+ UMA_HISTOGRAM_BOOLEAN("ChromeOS.GAIA.WebViewFlow",
+ StartupUtils::IsWebviewSigninEnabled());
+}
+
// The Task posted to PostTaskAndReply in StartClearingDnsCache on the IO
// thread.
void ClearDnsCache(IOThread* io_thread) {
@@ -420,6 +425,8 @@ void GaiaScreenHandler::HandleCompleteAuthentication(
if (!Delegate())
return;
+ RecordGAIAFlowTypeHistogram();
+
DCHECK(!email.empty());
DCHECK(!gaia_id.empty());
const std::string sanitized_email = gaia::SanitizeEmail(email);
@@ -436,6 +443,8 @@ void GaiaScreenHandler::HandleCompleteAuthenticationAuthCodeOnly(
if (!Delegate())
return;
+ RecordGAIAFlowTypeHistogram();
+
UserContext user_context;
user_context.SetAuthFlow(UserContext::AUTH_FLOW_EASY_BOOTSTRAP);
user_context.SetAuthCode(auth_code);
@@ -577,6 +586,7 @@ void GaiaScreenHandler::DoCompleteLogin(const std::string& gaia_id,
if (using_saml && !using_saml_api_)
RecordSAMLScrapingVerificationResultInHistogram(true);
+ RecordGAIAFlowTypeHistogram();
DCHECK(!typed_email.empty());
DCHECK(!gaia_id.empty());
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698