Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1009453003: New metric to track usage of the new GAIA flow. (Closed)

Created:
5 years, 9 months ago by Ivan Podogov
Modified:
5 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

New metric to track usage of the new GAIA flow. BUG=464051 Committed: https://crrev.com/97f445516b8c834ab30955a7b0386d0de393e2b9 Cr-Commit-Position: refs/heads/master@{#320880}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Document when the value is reported. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 4 chunks +10 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Ivan Podogov
PTAL
5 years, 9 months ago (2015-03-13 19:07:50 UTC) #2
Ilya Sherman
I'm a little confused -- are users choosing which endpoint they hit? If so, why ...
5 years, 9 months ago (2015-03-13 23:11:34 UTC) #3
Ivan Podogov
On 2015/03/13 23:11:34, Ilya Sherman wrote: > I'm a little confused -- are users choosing ...
5 years, 9 months ago (2015-03-14 14:16:06 UTC) #4
Ilya Sherman
LGTM
5 years, 9 months ago (2015-03-17 01:50:14 UTC) #5
Dmitry Polukhin
lgtm
5 years, 9 months ago (2015-03-17 07:30:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009453003/20001
5 years, 9 months ago (2015-03-17 07:34:59 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 08:49:21 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 08:50:05 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/97f445516b8c834ab30955a7b0386d0de393e2b9
Cr-Commit-Position: refs/heads/master@{#320880}

Powered by Google App Engine
This is Rietveld 408576698