Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1009443002: Hide Symbol implementation in a closure. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Hide Symbol implementation in a closure. R=jkummerow@chromium.org Committed: https://crrev.com/c67521794a084e992d030bcca8357216255981ac Cr-Commit-Position: refs/heads/master@{#27185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -57 lines) Patch
M src/harmony-array.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-tostring.js View 2 chunks +1 line, -2 lines 0 comments Download
M src/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M src/mirror-debugger.js View 1 chunk +1 line, -1 line 0 comments Download
M src/string.js View 1 chunk +1 line, -1 line 0 comments Download
M src/symbol.js View 3 chunks +49 lines, -51 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Yang
5 years, 9 months ago (2015-03-13 12:25:09 UTC) #1
Yang
On 2015/03/13 12:25:09, Yang wrote: Stats: old: Deserialization will reserve: 805128 bytes for startup 239192 ...
5 years, 9 months ago (2015-03-13 12:25:34 UTC) #2
Jakob Kummerow
lgtm
5 years, 9 months ago (2015-03-13 14:16:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009443002/1
5 years, 9 months ago (2015-03-13 14:34:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-13 15:08:19 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 15:08:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c67521794a084e992d030bcca8357216255981ac
Cr-Commit-Position: refs/heads/master@{#27185}

Powered by Google App Engine
This is Rietveld 408576698