Convert PepperBrowserConnection to be a RenderFrameObserver.

Convert PepperBrowserConnection to be a RenderFrameObserver.

BUG=245126
R=nasko@chromium.org, yzshen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238502

[nasko, 2013-12-03 18:27:52]

Couple of minor issues. Also, adding site-isolation-reviews@ so those CLs are
visible to the rest of the team.

https://codereview.chromium.org/100943002/diff/30001/content/renderer/pepper/...
File content/renderer/pepper/pepper_browser_connection.h (right):

https://codereview.chromium.org/100943002/diff/30001/content/renderer/pepper/...
content/renderer/pepper/pepper_browser_connection.h:20: class GURL;
Why is this new declaration needed?

https://codereview.chromium.org/100943002/diff/30001/content/renderer/pepper/...
File content/renderer/pepper/renderer_ppapi_host_impl.cc (right):

https://codereview.chromium.org/100943002/diff/30001/content/renderer/pepper/...
content/renderer/pepper/renderer_ppapi_host_impl.cc:136: PP_Instance instance)
const  {
nit: indent only 4 spaces.

[jam, 2013-12-03 20:32:09]

hold off on looking at this more. It turns out I need to combine this with some
other pepper changes because it won't work as is. I'll add a pepper owner to
take a look.

On 2013/12/03 18:27:52, nasko wrote:
> Couple of minor issues. Also, adding site-isolation-reviews@ so those CLs are
> visible to the rest of the team.

doh, i've been forgetting that again, thanks

https://codereview.chromium.org/100943002/diff/30001/content/renderer/pepper/...
File content/renderer/pepper/pepper_browser_connection.h (right):

https://codereview.chromium.org/100943002/diff/30001/content/renderer/pepper/...
content/renderer/pepper/pepper_browser_connection.h:20: class GURL;
On 2013/12/03 18:27:52, nasko wrote:
> Why is this new declaration needed?

because it was forward declared in render_view_observer.h but not
render_frame_observer.h

https://codereview.chromium.org/100943002/diff/30001/content/renderer/pepper/...
File content/renderer/pepper/renderer_ppapi_host_impl.cc (right):

https://codereview.chromium.org/100943002/diff/30001/content/renderer/pepper/...
content/renderer/pepper/renderer_ppapi_host_impl.cc:136: PP_Instance instance)
const  {
On 2013/12/03 18:27:52, nasko wrote:
> nit: indent only 4 spaces.

Done.

[jam, 2013-12-03 21:57:51]

ptal

yzshen: src\ppapi and other pepper code under content if you wish
nasko: whatever you reviewed before

[nasko, 2013-12-03 22:28:22]

LGTM

[yzshen1, 2013-12-03 22:35:19]

LGTM