Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1009413002: Revert "base: Implement browser process support for discardable memory." (Closed)

Created:
5 years, 9 months ago by Stephen White
Modified:
5 years, 9 months ago
Reviewers:
reveman
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, mlamouri+watch-content_chromium.org, sadrul, tfarina, mlamouri+watch-notifications_chromium.org, jam, gavinp+memory_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, kalyank, peter+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "base: Implement browser process support for discardable memory." This reverts commit ee5ad4b13cc36b7ee494bc2b04a356d73ad32e3a. Was causing asserts in webkit_unit_tests, e.g., [ RUN ] DeferredImageDecoderTest.drawIntoSkPicture Received signal 11 SEGV_MAPERR 000000000000 http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/45563 BUG= TBR=reveman Committed: https://chromium.googlesource.com/chromium/src/+/2e0b0cf7137afb10e7db275c53d9b98da9205d47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -215 lines) Patch
M ash/test/test_suite.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/test/test_suite.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/base.gyp View 2 chunks +1 line, -2 lines 0 comments Download
M base/memory/discardable_memory_shmem_allocator.cc View 2 chunks +42 lines, -1 line 0 comments Download
A base/memory/discardable_memory_unittest.cc View 1 chunk +64 lines, -0 lines 0 comments Download
M base/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D base/test/test_discardable_memory_shmem_allocator.h View 1 chunk +0 lines, -28 lines 0 comments Download
D base/test/test_discardable_memory_shmem_allocator.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/test/base/chrome_unit_test_suite.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/base/chrome_unit_test_suite.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/common/host_discardable_shared_memory_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/host_discardable_shared_memory_manager.cc View 8 chunks +54 lines, -105 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M ui/app_list/test/run_all_unittests.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M ui/message_center/test/run_all_unittests.cc View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2e0b0cf7137afb10e7db275c53d9b98da9205d47 Cr-Commit-Position: refs/heads/master@{#320746}
5 years, 9 months ago (2015-03-16 17:45:29 UTC) #1
Stephen White
5 years, 9 months ago (2015-03-16 17:45:45 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2e0b0cf7137afb10e7db275c53d9b98da9205d47 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698