Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1009403004: Revert of Delay font cache building by few seconds to yield for startup resource contention. (Closed)

Created:
5 years, 9 months ago by Vangelis Kokkevis
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Delay font cache building by few seconds to yield for startup resource contention. (patchset #3 id:40001 of https://codereview.chromium.org/992413003/) Reason for revert: Suspected to be causing failures on Intel Release GPU bot. See crbug.com/467706 Original issue's description: > Delay font cache building by few seconds to yield for startup resource contention. > > During first renderer start there are lot of things happening simultaneously some of them are: > 1. Renderer is going through all font files on the system to create a font collection. > 2. Renderer loading up startup URL, accessing HTML/JS File cache, net activity etc. > 3. Extension initialization. > > We delay building of this cache mainly to avoid parallel font file loading along with Renderer. Some systems have significant number of font files which takes long time process. > > BUG=458751, 436195 > R=cpu,scottmg > > Committed: https://crrev.com/787e29c61825173adaf3414ff8e3d3c0c26f529b > Cr-Commit-Position: refs/heads/master@{#320226} TBR=cpu@chromium.org,scottmg@chromium.org,gab@chromium.org,shrikant@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=458751, 436195 Committed: https://crrev.com/853deaf9674b69c01794888e53a50571c62833ef Cr-Commit-Position: refs/heads/master@{#320811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +3 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vangelis Kokkevis
Created Revert of Delay font cache building by few seconds to yield for startup resource ...
5 years, 9 months ago (2015-03-16 22:46:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009403004/1
5 years, 9 months ago (2015-03-16 22:46:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 22:47:48 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 22:48:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/853deaf9674b69c01794888e53a50571c62833ef
Cr-Commit-Position: refs/heads/master@{#320811}

Powered by Google App Engine
This is Rietveld 408576698