Refactor the avatar button/icon class

chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc

Index: chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
index 1d0f219a09bdd0966bd8ae6cf4e21f33053b0fea..f5e822c47f3c7a9a149b6b76b97b3105f9dd42b7 100644
--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
@@ -11,6 +11,8 @@
 #include "chrome/browser/ui/views/tab_icon_view.h"
 #include "chrome/browser/ui/views/tabs/tab.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "chrome/test/base/testing_profile_manager.h"
 #include "components/signin/core/common/profile_management_switches.h"
 #include "ui/gfx/image/image_skia.h"
 #include "ui/gfx/image/image_skia_rep.h"
@@ -134,11 +136,13 @@ class TestLayoutDelegate : public OpaqueBrowserFrameViewLayoutDelegate {
 
 class OpaqueBrowserFrameViewLayoutTest : public views::ViewsTestBase {
  public:
-  OpaqueBrowserFrameViewLayoutTest() {}
+  OpaqueBrowserFrameViewLayoutTest()
+      : profile_manager_(TestingBrowserProcess::GetGlobal()) {}

[msw, 2015/04/01 01:30:16]

nit: can you inline this in SetUp and remove the class member?

[yao, 2015/04/10 00:43:32]

Done.

   ~OpaqueBrowserFrameViewLayoutTest() override {}
 
   void SetUp() override {
     views::ViewsTestBase::SetUp();
+    ASSERT_TRUE(profile_manager_.SetUp());

[msw, 2015/04/01 01:30:16]

Why is this necessary? Can you add a comment?

[yao, 2015/04/10 00:43:32]

Done.

 
     delegate_.reset(new TestLayoutDelegate);
     layout_manager_ = new OpaqueBrowserFrameViewLayout(delegate_.get());
@@ -260,6 +264,8 @@ class OpaqueBrowserFrameViewLayoutTest : public views::ViewsTestBase {
   AvatarMenuButton* menu_button_;
   views::MenuButton* new_avatar_button_;
 
+  TestingProfileManager profile_manager_;
+
   DISALLOW_COPY_AND_ASSIGN(OpaqueBrowserFrameViewLayoutTest);
 };