Refactor the avatar button/icon class

chrome/browser/ui/views/profiles/avatar_base_controller.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_PROFILES_AVATAR_BASE_CONTROLLER_H_
+#define CHROME_BROWSER_UI_VIEWS_PROFILES_AVATAR_BASE_CONTROLLER_H_

[noms (inactive), 2015/03/26 15:26:56]

nit: I think Mac UI files are "controllers" but not on windows. So, maybe,
avatar_base_button, avatar_icon_button, avatar_button? What do you think?

[yao, 2015/03/26 18:45:01]

Changed to avatar_base_button.

[noms (inactive), 2015/03/30 14:54:54]

Will you do the other renames in a separate CL?

[yao, 2015/03/30 15:02:16]

This file has been reverted/deleted. 

I though I renamed everything. Is there anything I'm missing? 

[noms (inactive), 2015/03/30 15:04:00]

I had suggested renaming new_avatar_button to avatar_button, and
avatar_menu_button to avatar_icon to match their intent and the Mac hierarchy
(also because at this point the new_avatar_button is no longer really new)

[yao, 2015/03/30 23:12:12]

Ic, I misunderstood your initial comments, but now I got it. 

I took a look at the code, the renaming will touch quite some files and I think
it will be better if I rename them in a separate CL, unless you have a different
preference. 

[noms (inactive), 2015/03/31 20:47:06]

Sounds good!

+
+#include "chrome/browser/profiles/profile_info_cache_observer.h"
+
+class Browser;
+
+// This view controller manages the button that sits in the top of the window

[noms (inactive), 2015/03/26 15:26:56]

nit: . at the end of the comment

[noms (inactive), 2015/03/26 15:26:56]

nit: This view (no controller)

[yao, 2015/03/26 18:45:01]

Done.

[yao, 2015/03/26 18:45:01]

Done.

+// frame and displays the active profile's info when using multi-profiles
+class AvatarBaseController : public ProfileInfoCacheObserver {
+ public:
+  explicit AvatarBaseController(Browser* browser);
+  ~AvatarBaseController() override;
+
+ protected:
+  Browser* browser() const {return browser_;}
+
+ private:
+  // ProfileInfoCacheObserver:
+  void OnProfileAdded(const base::FilePath& profile_path) override;
+  void OnProfileWasRemoved(const base::FilePath& profile_path,
+                           const base::string16& profile_name) override;
+  void OnProfileNameChanged(const base::FilePath& profile_path,
+                            const base::string16& old_profile_name) override;
+  void OnProfileAvatarChanged(const base::FilePath& profile_path) override;
+  void OnProfileSupervisedUserIdChanged(
+      const base::FilePath& profile_path) override;
+
+  // Called when the profile info cache has changed, which means we might
+  // have to update the icon/text of the button.
+  virtual void Update();
+
+  Browser* browser_;
+
+  DISALLOW_COPY_AND_ASSIGN(AvatarBaseController);
+};
+
+#endif  // CHROME_BROWSER_UI_VIEWS_PROFILES_AVATAR_BASE_CONTROLLER_H_