tools/check-name-clashes.py - Issue 1009373002: Remove BLACKLIST from check-name-clashes.py, it's wrong nowadays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/check-name-clashes.py

Issue 1009373002: Remove BLACKLIST from check-name-clashes.py, it's wrong nowadays. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/check-name-clashes.py

diff --git a/tools/check-name-clashes.py b/tools/check-name-clashes.py

index 862cb4410f5dcc4e9c1c760de307cc95758fc6bf..fcc70a5281e5e846f9b53cb6692a27cdde1f8339 100755

--- a/tools/check-name-clashes.py

+++ b/tools/check-name-clashes.py

@@ -11,7 +11,6 @@ import sys

FILENAME = "src/runtime/runtime.h"

LISTHEAD = re.compile(r"#define\s+(\w+LIST\w*)$(\w+)$")

LISTBODY = re.compile(r".*\\$")

-BLACKLIST = ['INLINE_FUNCTION_LIST', 'INLINE_OPTIMIZED_FUNCTION_LIST']

class Function(object):

@@ -32,7 +31,7 @@ def FindLists(filename):

for line in f:

if mode == "SEARCHING":

match = LISTHEAD.match(line)

- if match and match.group(1) not in BLACKLIST:

+ if match:

mode = "APPENDING"

current_list.append(line)

else:

« no previous file with comments | « src/x87/code-stubs-x87.cc ('k') | no next file » | no next file with comments »