Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1009373002: Remove BLACKLIST from check-name-clashes.py, it's wrong nowadays. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove BLACKLIST from check-name-clashes.py, it's wrong nowadays. Fix the resulting warnings by renaming things apart. BUG=v8:3947 LOG=n Committed: https://crrev.com/cf1c4911b9c3d0fad3957bd1245f36a8d2a725ea Cr-Commit-Position: refs/heads/master@{#27219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -47 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/math.js View 7 chunks +11 lines, -11 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/regexp.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-regexp.cc View 2 chunks +1 line, -7 lines 0 comments Download
M src/string.js View 4 chunks +5 lines, -5 lines 0 comments Download
M src/v8natives.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/check-name-clashes.py View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 9 months ago (2015-03-16 12:20:31 UTC) #2
Jakob Kummerow
lgtm
5 years, 9 months ago (2015-03-16 12:26:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009373002/1
5 years, 9 months ago (2015-03-16 12:43:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 13:08:47 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 13:08:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf1c4911b9c3d0fad3957bd1245f36a8d2a725ea
Cr-Commit-Position: refs/heads/master@{#27219}

Powered by Google App Engine
This is Rietveld 408576698