Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 100933002: Add a no-op measurement (Closed)

Created:
7 years ago by nduca
Modified:
7 years ago
Reviewers:
tonyg, eseidel
CC:
chromium-reviews, chrome-speed-team+watch_google.com, iannucci, Julie Parent
Visibility:
Public.

Description

Add a no-op measurement Some pages you just want to let run while the profiler runs. This no_op measurement does just that. R=tonyg CC=eseidel Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238370

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
A tools/perf/measurements/no_op.py View 1 chunk +21 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
nduca
ptal
7 years ago (2013-12-03 02:41:56 UTC) #1
tonyg
lgtm This is cool. Will also be useful with the new --interactive flag. https://codereview.chromium.org/100933002/diff/1/tools/perf/measurements/no_op.py File ...
7 years ago (2013-12-03 02:46:44 UTC) #2
eseidel
It appears "CC=" doesn't actually seem to work. I wonder if it is supposed to. ...
7 years ago (2013-12-03 03:06:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/100933002/1
7 years ago (2013-12-03 03:31:35 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-03 12:28:05 UTC) #5
Message was sent while issue was closed.
Change committed as 238370

Powered by Google App Engine
This is Rietveld 408576698