Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1009323002: Delete dead store buffer verification code and code that changes the store buffer in debug mode. (Closed)

Created:
5 years, 9 months ago by Hannes Payer (out of office)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Delete dead store buffer verification code and code that changes the store buffer in debug mode. BUG= Committed: https://crrev.com/3e924dd067c6a02f0eafbc2541dea15e79ae5ac2 Cr-Commit-Position: refs/heads/master@{#27214}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -225 lines) Patch
M src/heap/heap.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +0 lines, -141 lines 0 comments Download
M src/heap/store-buffer.h View 1 2 chunks +0 lines, -11 lines 0 comments Download
M src/heap/store-buffer.cc View 1 3 chunks +0 lines, -69 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Hannes Payer (out of office)
5 years, 9 months ago (2015-03-16 10:49:18 UTC) #2
Jarin
lgtm
5 years, 9 months ago (2015-03-16 11:30:43 UTC) #3
Michael Starzinger
LGTM.
5 years, 9 months ago (2015-03-16 11:37:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009323002/20001
5 years, 9 months ago (2015-03-16 11:38:46 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 11:40:17 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 11:40:26 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e924dd067c6a02f0eafbc2541dea15e79ae5ac2
Cr-Commit-Position: refs/heads/master@{#27214}

Powered by Google App Engine
This is Rietveld 408576698