Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1009313004: Files.app: Show details of drive sync progress. (Closed)

Created:
5 years, 9 months ago by hirono
Modified:
5 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Show details of drive sync progress. * Show the open button of progress center if it shows drive sync item. * If the progress center panel is opened, we show the progress bar for the drive sync item. BUG=450630 TEST=FileManagerJsTest.ProgressCenterItemGroupTest Committed: https://crrev.com/685eb7e384bba764ae54b02ce8df39761b1c93d0 Cr-Commit-Position: refs/heads/master@{#321548}

Patch Set 1 #

Patch Set 2 : Add test. #

Total comments: 2

Patch Set 3 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -28 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/progress_center_item_group.js View 1 2 3 chunks +15 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/progress_center_item_group_unittest.js View 1 12 chunks +64 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hirono
PTAL, thanks!
5 years, 9 months ago (2015-03-18 06:49:15 UTC) #2
fukino
This CL is lgtm with a nit, but maybe we should ask PM if the ...
5 years, 9 months ago (2015-03-18 08:09:00 UTC) #3
hirono
The behavior was fixed. crbug.com/469039. Thanks! https://codereview.chromium.org/1009313004/diff/20001/ui/file_manager/file_manager/foreground/js/progress_center_item_group.js File ui/file_manager/file_manager/foreground/js/progress_center_item_group.js (right): https://codereview.chromium.org/1009313004/diff/20001/ui/file_manager/file_manager/foreground/js/progress_center_item_group.js#newcode149 ui/file_manager/file_manager/foreground/js/progress_center_item_group.js:149: // If previous ...
5 years, 9 months ago (2015-03-20 10:30:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009313004/40001
5 years, 9 months ago (2015-03-20 10:31:55 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-20 11:05:59 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 11:06:28 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/685eb7e384bba764ae54b02ce8df39761b1c93d0
Cr-Commit-Position: refs/heads/master@{#321548}

Powered by Google App Engine
This is Rietveld 408576698