|
|
DescriptionCurrent RSS on linux and android too?
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/eec84e324ee47f19b7e9c22d3454622d7a21da2e
Patch Set 1 #Patch Set 2 : include #Patch Set 3 : deps #Patch Set 4 : fixes #Patch Set 5 : more #Patch Set 6 : working on desktop #Patch Set 7 : note #Patch Set 8 : fscanf return value #Patch Set 9 : initialize #Messages
Total messages: 30 (12 generated)
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009313003/20001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-03-16 23:46 UTC
The CQ bit was unchecked by mtklein@google.com
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009313003/80001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-03-17 00:05 UTC
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...) Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...)
mtklein@google.com changed reviewers: + halcanary@google.com
Will SkData::NewFromFileName not work with "/proc/self/statm" ?
On 2015/03/16 18:39:23, mtklein wrote: > Will SkData::NewFromFileName not work with "/proc/self/statm" ? it can't be mmaped, apparently. int sk_tools::getCurrResidentSetSizeMB() { SkFILEStream statm("/proc/self/statm"); SkASSERT(statm.isValid()); // statm contains: program-size rss shared text lib data // dirty, all in page counts. char buffer[1024]; size_t read = statm.read(buffer, sizeof(buffer) - 1); SkASSERT(read < sizeof(buffer)); buffer[read] = '\0'; long rssPages; SkDEBUGCODE(int rc = ) sscanf(buffer, "%*d %ld", &rssPages); SkASSERT(rc == 1); long pageSize = sysconf(_SC_PAGESIZE); return SkToInt(((int64_t)rssPages * pageSize) / (1024 * 1024)); }
Okay, latest patch is working on my desktop and N7. Please take another look?
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009313003/100001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-03-17 22:57 UTC
The CQ bit was checked by mtklein@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009313003/120001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-03-17 23:00 UTC
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...)
The CQ bit was checked by mtklein@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from halcanary@google.com Link to the patchset: https://codereview.chromium.org/1009313003/#ps140001 (title: "fscanf return value")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009313003/140001
The CQ bit was checked by mtklein@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from halcanary@google.com Link to the patchset: https://codereview.chromium.org/1009313003/#ps160001 (title: "initialize")
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Cl...)
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009313003/160001
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as https://skia.googlesource.com/skia/+/eec84e324ee47f19b7e9c22d3454622d7a21da2e |