Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1009313002: Rewrite fast/multicol/*nested-columns.html as reftests. (Closed)

Created:
5 years, 9 months ago by mstensho (USE GERRIT)
Modified:
5 years, 9 months ago
Reviewers:
andersr, rune
CC:
blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Rewrite fast/multicol/*nested-columns.html as reftests. The vertical-rl version fails (both before and after the rewrite) with the region based multicol implementation. Reported bug 467477 for that. BUG=386567 R=andersr@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -1214 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +1 line, -3 lines 0 comments Download
M LayoutTests/fast/multicol/nested-columns.html View 1 chunk +12 lines, -17 lines 0 comments Download
A LayoutTests/fast/multicol/nested-columns-expected.html View 1 chunk +14 lines, -0 lines 0 comments Download
M LayoutTests/fast/multicol/vertical-lr/nested-columns.html View 1 chunk +12 lines, -17 lines 0 comments Download
A LayoutTests/fast/multicol/vertical-lr/nested-columns-expected.html View 1 chunk +15 lines, -0 lines 0 comments Download
M LayoutTests/fast/multicol/vertical-rl/nested-columns.html View 1 chunk +12 lines, -17 lines 0 comments Download
A LayoutTests/fast/multicol/vertical-rl/nested-columns-expected.html View 1 chunk +15 lines, -0 lines 0 comments Download
D LayoutTests/platform/android/fast/multicol/nested-columns-expected.txt View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/platform/android/fast/multicol/vertical-lr/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/fast/multicol/vertical-lr/nested-columns-expected.txt View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/platform/android/fast/multicol/vertical-rl/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/fast/multicol/vertical-rl/nested-columns-expected.txt View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/nested-columns-expected.txt View 1 chunk +0 lines, -79 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-lr/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-lr/nested-columns-expected.txt View 1 chunk +0 lines, -79 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-rl/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-rl/nested-columns-expected.txt View 1 chunk +0 lines, -79 lines 0 comments Download
D LayoutTests/platform/mac-lion/fast/multicol/vertical-lr/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/multicol/vertical-rl/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/multicol/vertical-lr/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/multicol/vertical-rl/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/nested-columns-expected.txt View 1 chunk +0 lines, -82 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-lr/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-lr/nested-columns-expected.txt View 1 chunk +0 lines, -82 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-rl/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-rl/nested-columns-expected.txt View 1 chunk +0 lines, -82 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/nested-columns-expected.txt View 1 chunk +0 lines, -79 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-lr/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-lr/nested-columns-expected.txt View 1 chunk +0 lines, -79 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-rl/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-rl/nested-columns-expected.txt View 1 chunk +0 lines, -79 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/nested-columns-expected.txt View 1 chunk +0 lines, -82 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-lr/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-lr/nested-columns-expected.txt View 1 chunk +0 lines, -82 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-rl/nested-columns-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-rl/nested-columns-expected.txt View 1 chunk +0 lines, -82 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mstensho (USE GERRIT)
5 years, 9 months ago (2015-03-16 13:02:19 UTC) #1
mstensho (USE GERRIT)
@rune - I usually give reviews like this to andersr, but he's away. PTAL?
5 years, 9 months ago (2015-03-18 16:28:41 UTC) #3
rune
lgtm
5 years, 9 months ago (2015-03-19 00:01:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009313002/1
5 years, 9 months ago (2015-03-19 10:35:04 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 12:09:44 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192155

Powered by Google App Engine
This is Rietveld 408576698