Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1009303002: Revert of Per-renderer WebSocket throttling (Closed)

Created:
5 years, 9 months ago by henrika (OOO until Aug 14)
Modified:
5 years, 9 months ago
Reviewers:
hiroshige, Adam Rice
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Per-renderer WebSocket throttling (patchset #13 id:300001 of https://codereview.chromium.org/972963002/) Reason for revert: Suspected to have caused WebSocket breakage. Failure seen on apprtc.appspot.com and in browser_tests. Run the manual MANUAL_WorksWithAppRTC test for repro. See https://code.google.com/p/chromium/issues/detail?id=467471&thanks=467471&ts=1426498439 for details. Original issue's description: > Per-renderer WebSocket throttling > > Design Doc: > https://docs.google.com/document/d/1aw2oN5PKfk-1gLnBrlv1OwLA8K3-ykM2ckwX2lubTg4/edit?usp=sharing > > BUG=459377 > > Committed: https://crrev.com/58d344316cf2b2cc110619c0fea4979ef143b3a9 > Cr-Commit-Position: refs/heads/master@{#320074} TBR=ricea@chromium.org,hiroshige@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459377 Committed: https://crrev.com/3464a08a0c157c57ea02881687f10058303de8ea Cr-Commit-Position: refs/heads/master@{#320705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -437 lines) Patch
M content/browser/renderer_host/websocket_dispatcher_host.h View 6 chunks +13 lines, -48 lines 0 comments Download
M content/browser/renderer_host/websocket_dispatcher_host.cc View 7 chunks +5 lines, -95 lines 0 comments Download
M content/browser/renderer_host/websocket_dispatcher_host_unittest.cc View 6 chunks +13 lines, -208 lines 0 comments Download
M content/browser/renderer_host/websocket_host.h View 5 chunks +1 line, -26 lines 0 comments Download
M content/browser/renderer_host/websocket_host.cc View 4 chunks +4 lines, -60 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
henrika (OOO until Aug 14)
Created Revert of Per-renderer WebSocket throttling
5 years, 9 months ago (2015-03-16 09:43:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009303002/1
5 years, 9 months ago (2015-03-16 09:43:57 UTC) #2
commit-bot: I haz the power
Failed to apply patch for content/browser/renderer_host/websocket_dispatcher_host_unittest.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 9 months ago (2015-03-16 09:44:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009303002/1
5 years, 9 months ago (2015-03-16 10:29:55 UTC) #7
commit-bot: I haz the power
Failed to apply patch for content/browser/renderer_host/websocket_dispatcher_host_unittest.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 9 months ago (2015-03-16 10:30:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009303002/1
5 years, 9 months ago (2015-03-16 10:31:53 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 10:32:26 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3464a08a0c157c57ea02881687f10058303de8ea Cr-Commit-Position: refs/heads/master@{#320705}
5 years, 9 months ago (2015-03-16 10:33:01 UTC) #14
hiroshige
5 years, 9 months ago (2015-03-16 12:55:35 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1011743002/ by hiroshige@chromium.org.

The reason for reverting is: The breakage still persists
https://crbug.com/467471 after the original CL was reverted..

Powered by Google App Engine
This is Rietveld 408576698